Source/core/dom/DOMImplementation.idl - Issue 1108293002: Make DOMImplementation.hasFeature() always return true.

Side by Side Diff: Source/core/dom/DOMImplementation.idl

Issue 1108293002: Make DOMImplementation.hasFeature() always return true. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fix tests Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/core/dom/DOMImplementation.h ('K') | « Source/core/dom/DOMImplementation.cpp ('k') | Source/core/frame/UseCounter.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2006, 2007 Apple Inc. All rights reserved.	2 * Copyright (C) 2006, 2007 Apple Inc. All rights reserved.

3 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>	3 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>

4 *	4 *

5 * This library is free software; you can redistribute it and/or	5 * This library is free software; you can redistribute it and/or

6 * modify it under the terms of the GNU Library General Public	6 * modify it under the terms of the GNU Library General Public

7 * License as published by the Free Software Foundation; either	7 * License as published by the Free Software Foundation; either

8 * version 2 of the License, or (at your option) any later version.	8 * version 2 of the License, or (at your option) any later version.

9 *	9 *

10 * This library is distributed in the hope that it will be useful,	10 * This library is distributed in the hope that it will be useful,

(...skipping 13 matching lines...) Expand all Loading...
24 SetWrapperReferenceFrom=document,	24 SetWrapperReferenceFrom=document,

25 TypeChecking=Interface,	25 TypeChecking=Interface,

26 WillBeGarbageCollected,	26 WillBeGarbageCollected,

27 ] interface DOMImplementation {	27 ] interface DOMImplementation {

28 [NewObject, RaisesException] DocumentType createDocumentType(DOMString quali fiedName, DOMString publicId, DOMString systemId);	28 [NewObject, RaisesException] DocumentType createDocumentType(DOMString quali fiedName, DOMString publicId, DOMString systemId);

29 [NewObject, RaisesException] XMLDocument createDocument(DOMString? namespace URI, [TreatNullAs=EmptyString] DOMString qualifiedName, optional DocumentType? d octype = null);	29 [NewObject, RaisesException] XMLDocument createDocument(DOMString? namespace URI, [TreatNullAs=EmptyString] DOMString qualifiedName, optional DocumentType? d octype = null);

30 // FIXME: createHTMLDocument should return a Document. crbug.com/238368	30 // FIXME: createHTMLDocument should return a Document. crbug.com/238368

31 // FIXME: The title argument should not have a default value. crbug.com/3358 71	31 // FIXME: The title argument should not have a default value. crbug.com/3358 71

32 [NewObject] HTMLDocument createHTMLDocument(optional DOMString title = null) ;	32 [NewObject] HTMLDocument createHTMLDocument(optional DOMString title = null) ;

33	33

34 // FIXME: hasFeature should take no arguments and always return true. crbug. com/429536	34 // useless; always returns true
	philipj_slow 2015/04/30 13:05:23 Can you put this on the same line, so that it matc Can you put this on the same line, so that it matches the spec's IDL character-by-character as far as possible? Erik Dahlström (inactive) 2015/04/30 13:23:47 I'd have gladly fixed that before landing the patc Show quoted text On 2015/04/30 13:05:23, philipj_UTC2 wrote: > Can you put this on the same line, so that it matches the spec's IDL > character-by-character as far as possible? I'd have gladly fixed that before landing the patch, but this didn't make the cut, sorry.
35 [ImplementedAs=hasFeatureForBindings, MeasureAs=DOMImplementationHasFeature]	35 boolean hasFeature();

36 boolean hasFeature(DOMString feature, DOMString? version);

37 };	36 };

OLD	NEW