Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: Source/core/svg/SVGTests.cpp

Issue 1108293002: Make DOMImplementation.hasFeature() always return true. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: windows compilefix attempt Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/frame/UseCounter.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 } 50 }
51 51
52 bool SVGTests::hasExtension(const String&) 52 bool SVGTests::hasExtension(const String&)
53 { 53 {
54 // FIXME: Implement me! 54 // FIXME: Implement me!
55 return false; 55 return false;
56 } 56 }
57 57
58 bool SVGTests::isValid(Document& document) const 58 bool SVGTests::isValid(Document& document) const
59 { 59 {
60 if (m_requiredFeatures->isSpecified()) { 60 // No need to check requiredFeatures since hasFeature always returns true.
61 const Vector<String>& requiredFeatures = m_requiredFeatures->value()->va lues();
62 Vector<String>::const_iterator it = requiredFeatures.begin();
63 Vector<String>::const_iterator itEnd = requiredFeatures.end();
64 for (; it != itEnd; ++it) {
65 if (it->isEmpty())
66 return false;
67 if (!DOMImplementation::hasFeature(*it, String())) {
68 UseCounter::count(document, UseCounter::DOMImplementationHasFeat ureReturnFalseInternal);
69 return false;
70 }
71 }
72 }
73 61
74 if (m_systemLanguage->isSpecified()) { 62 if (m_systemLanguage->isSpecified()) {
75 bool matchFound = false; 63 bool matchFound = false;
76 64
77 const Vector<String>& systemLanguage = m_systemLanguage->value()->values (); 65 const Vector<String>& systemLanguage = m_systemLanguage->value()->values ();
78 Vector<String>::const_iterator it = systemLanguage.begin(); 66 Vector<String>::const_iterator it = systemLanguage.begin();
79 Vector<String>::const_iterator itEnd = systemLanguage.end(); 67 Vector<String>::const_iterator itEnd = systemLanguage.end();
80 for (; it != itEnd; ++it) { 68 for (; it != itEnd; ++it) {
81 if (*it == defaultLanguage().string().substring(0, 2)) { 69 if (*it == defaultLanguage().string().substring(0, 2)) {
82 matchFound = true; 70 matchFound = true;
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 } 110 }
123 111
124 void SVGTests::addSupportedAttributes(HashSet<QualifiedName>& supportedAttribute s) 112 void SVGTests::addSupportedAttributes(HashSet<QualifiedName>& supportedAttribute s)
125 { 113 {
126 supportedAttributes.add(SVGNames::requiredFeaturesAttr); 114 supportedAttributes.add(SVGNames::requiredFeaturesAttr);
127 supportedAttributes.add(SVGNames::requiredExtensionsAttr); 115 supportedAttributes.add(SVGNames::requiredExtensionsAttr);
128 supportedAttributes.add(SVGNames::systemLanguageAttr); 116 supportedAttributes.add(SVGNames::systemLanguageAttr);
129 } 117 }
130 118
131 } 119 }
OLDNEW
« no previous file with comments | « Source/core/frame/UseCounter.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698