PlzNavigate: Call DidStartLoading and DidStopLoading.

content/browser/frame_host/frame_tree_node.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/frame_tree_node.h"
 
 #include <queue>
 
 #include "base/command_line.h"
 #include "base/profiler/scoped_tracker.h"
@@ skipping 167 matching lines @@
       effective_sandbox_flags_ != replication_state_.sandbox_flags;
   effective_sandbox_flags_ = replication_state_.sandbox_flags;
   return did_change_flags;
 }
 
 void FrameTreeNode::SetNavigationRequest(
     scoped_ptr<NavigationRequest> navigation_request) {
   CHECK(base::CommandLine::ForCurrentProcess()->HasSwitch(
       switches::kEnableBrowserSideNavigation));
   ResetNavigationRequest(false);
-  // TODO(clamy): perform the StartLoading logic here.
+
+  // Force the throbber to start to keep it in sync with what is happening in
+  // the UI. Blink doesn't send throb notifications for JavaScript URLs, so it
+  // is not done here either.
+  if (!navigation_request->common_params().url.SchemeIs(
+          url::kJavaScriptScheme)) {

[clamy, 2015/04/28 11:42:56]

Could you add a TODO to set the boolean properly once we recognize same-document
navigation on the browser-side?

[Fabrice (no longer in Chrome), 2015/04/28 14:40:29]

Done.

+    DidStartLoading(true);
+  }
+
   navigation_request_ = navigation_request.Pass();
 }
 
 void FrameTreeNode::ResetNavigationRequest(bool is_commit) {
   CHECK(base::CommandLine::ForCurrentProcess()->HasSwitch(
       switches::kEnableBrowserSideNavigation));
   // Upon commit the current NavigationRequest will be reset. There should be no
   // cleanup performed since the navigation is still ongoing. If the reset
   // corresponds to a cancelation, the RenderFrameHostManager should clean up
   // any speculative RenderFrameHost it created for the navigation.
   if (navigation_request_ && !is_commit) {
-    // TODO(clamy): perform the StopLoading logic.
+    DidStopLoading();
     render_manager_.CleanUpNavigation();
   }
   navigation_request_.reset();
 }
 
 bool FrameTreeNode::has_started_loading() const {
   return loading_progress_ != kLoadingProgressNotStarted;
 }
 
 void FrameTreeNode::reset_loading_progress() {
@@ skipping 51 matching lines @@
       FROM_HERE_WITH_EXPLICIT_FUNCTION(
           "465796 FrameTreeNode::DidStopLoading::End"));
 }
 
 void FrameTreeNode::DidChangeLoadProgress(double load_progress) {
   loading_progress_ = load_progress;
   frame_tree_->UpdateLoadProgress();
 }
 
 }  // namespace content