Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1108203004: Test that chrome.runtime.onMessage isn't fired for chrome.runtime.sendMessage (Closed)

Created:
5 years, 7 months ago by not at google - send to devlin
Modified:
5 years, 7 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Test that chrome.runtime.onMessage isn't fired for chrome.runtime.sendMessage sent from the same context. This adds 2 tests, one that has always been the case, and a second regression test which r325585 accidentally fixed. BUG=479951 R=rdevlin.cronin@chromium.org Committed: https://crrev.com/b9dca05429b19ad398d1dbf7496b44a94ba0f306 Cr-Commit-Position: refs/heads/master@{#327409}

Patch Set 1 #

Total comments: 3

Patch Set 2 : no-copies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -0 lines) Patch
A chrome/test/data/extensions/api_test/messaging/connect/blank_frame.html View 1 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/messaging/connect/test.js View 2 chunks +58 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
not at google - send to devlin
https://codereview.chromium.org/1108203004/diff/1/chrome/test/data/extensions/api_test/messaging/connect/blank_frame.html File chrome/test/data/extensions/api_test/messaging/connect/blank_frame.html (right): https://codereview.chromium.org/1108203004/diff/1/chrome/test/data/extensions/api_test/messaging/connect/blank_frame.html#newcode10 chrome/test/data/extensions/api_test/messaging/connect/blank_frame.html:10: --> FYI I will upload with --no-detect-copies or --no-find-copies ...
5 years, 7 months ago (2015-04-28 21:42:07 UTC) #1
Devlin
lgtm https://codereview.chromium.org/1108203004/diff/1/chrome/test/data/extensions/api_test/messaging/connect/test.js File chrome/test/data/extensions/api_test/messaging/connect/test.js (right): https://codereview.chromium.org/1108203004/diff/1/chrome/test/data/extensions/api_test/messaging/connect/test.js#newcode298 chrome/test/data/extensions/api_test/messaging/connect/test.js:298: var stopFailing = failWhileListening(chrome.runtime.onMessage); nit: stopFailing is kinda ...
5 years, 7 months ago (2015-04-28 22:24:40 UTC) #2
not at google - send to devlin
https://codereview.chromium.org/1108203004/diff/1/chrome/test/data/extensions/api_test/messaging/connect/test.js File chrome/test/data/extensions/api_test/messaging/connect/test.js (right): https://codereview.chromium.org/1108203004/diff/1/chrome/test/data/extensions/api_test/messaging/connect/test.js#newcode298 chrome/test/data/extensions/api_test/messaging/connect/test.js:298: var stopFailing = failWhileListening(chrome.runtime.onMessage); On 2015/04/28 22:24:40, Devlin wrote: ...
5 years, 7 months ago (2015-04-28 22:46:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108203004/20001
5 years, 7 months ago (2015-04-28 22:47:34 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-29 01:22:14 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 01:23:08 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b9dca05429b19ad398d1dbf7496b44a94ba0f306
Cr-Commit-Position: refs/heads/master@{#327409}

Powered by Google App Engine
This is Rietveld 408576698