Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1108193002: Update _MSC_FULL_VER for 'final' RC bug workaround (Closed)

Created:
5 years, 8 months ago by scottmg
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Update _MSC_FULL_VER for 'final' RC bug workaround Repeat of https://codereview.chromium.org/1084763002/. The 'final' RC has changed the version number, but the bug will not be fixed until RTM. LOG=N R=jochen@chromium.org BUG=chromium:440500 Committed: https://crrev.com/bb940247d95a65ac4209c8bb7848ab3bc5205bf8 Cr-Commit-Position: refs/heads/master@{#28106}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/deoptimizer.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
scottmg
5 years, 8 months ago (2015-04-27 23:32:26 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-04-28 11:09:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108193002/1
5 years, 7 months ago (2015-04-28 11:09:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 11:33:43 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 11:33:58 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb940247d95a65ac4209c8bb7848ab3bc5205bf8
Cr-Commit-Position: refs/heads/master@{#28106}

Powered by Google App Engine
This is Rietveld 408576698