Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: tools/android/checkstyle/chromium-style-5.0.xml

Issue 1108173002: Roll //build, //native_client, and a few more targets of opportunity. Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Test fix Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/android/checkstyle/checkstyle.py ('k') | tools/android/findbugs_plugin/findbugs.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/android/checkstyle/chromium-style-5.0.xml
diff --git a/tools/android/checkstyle/chromium-style-5.0.xml b/tools/android/checkstyle/chromium-style-5.0.xml
index c43f7794f430506e3332b9fd178520dc2d45f866..9e56dd91a3858513e0336cb4560871c19183694c 100644
--- a/tools/android/checkstyle/chromium-style-5.0.xml
+++ b/tools/android/checkstyle/chromium-style-5.0.xml
@@ -101,8 +101,10 @@
<property name="severity" value="error"/>
</module>
<module name="NeedBraces">
- <property name="severity" value="info"/>
- <property name="tokens" value="LITERAL_FOR, LITERAL_WHILE, LITERAL_DO"/>
+ <message key="needBraces" value="if, for, while, and do require curly braces unless they are single-line statements."/>
+ <property name="severity" value="error"/>
+ <property name="tokens" value="LITERAL_FOR, LITERAL_WHILE, LITERAL_DO, LITERAL_IF"/>
+ <property name="allowSingleLineStatement" value="true"/>
</module>
<module name="EmptyBlock">
<property name="severity" value="error"/>
« no previous file with comments | « tools/android/checkstyle/checkstyle.py ('k') | tools/android/findbugs_plugin/findbugs.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698