Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: tools/clang/plugins/tests/virtual_specifiers.cpp

Issue 1108173002: Roll //build, //native_client, and a few more targets of opportunity. Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Test fix Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/plugins/tests/test.sh ('k') | tools/clang/plugins/tests/virtual_specifiers.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/tests/virtual_specifiers.cpp
diff --git a/tools/clang/plugins/tests/virtual_specifiers.cpp b/tools/clang/plugins/tests/virtual_specifiers.cpp
index 28321e8bdf5c29aed7fd2343b398eb8cad360b6c..210324809f1ee7d7a41ad3f3108a61f52d6ffd9f 100644
--- a/tools/clang/plugins/tests/virtual_specifiers.cpp
+++ b/tools/clang/plugins/tests/virtual_specifiers.cpp
@@ -5,6 +5,8 @@
// Tests for chromium style checks for virtual/override/final specifiers on
// virtual methods.
+#include <windows.h>
+
// Purposely use macros to test that the FixIt hints don't try to remove the
// macro body.
#define OVERRIDE override
@@ -79,7 +81,13 @@ class PureVirtualOverride : public Base {
virtual void F() override = 0;
};
-// Finally, some simple sanity tests that overrides in the testing namespace
+// Test that the redundant virtual warning is suppressed when the virtual
+// keyword comes from a macro in a system header.
+class COMIsAwesome : public Base {
+ STDMETHOD(F)() override = 0;
+};
+
+// Some tests that overrides in the testing namespace
// don't trigger warnings, except for testing::Test.
namespace testing {
« no previous file with comments | « tools/clang/plugins/tests/test.sh ('k') | tools/clang/plugins/tests/virtual_specifiers.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698