Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: testing/buildbot/PRESUBMIT.py

Issue 1108173002: Roll //build, //native_client, and a few more targets of opportunity. Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Test fix Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « testing/android/native_test_util.cc ('k') | testing/buildbot/chromium.chrome.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/buildbot/PRESUBMIT.py
diff --git a/testing/PRESUBMIT.py b/testing/buildbot/PRESUBMIT.py
similarity index 70%
copy from testing/PRESUBMIT.py
copy to testing/buildbot/PRESUBMIT.py
index 5e8fc90625635e825a37dd1cb5faabf546e31fe7..a74562a656dc81dfa03724f4a7d6944be687856a 100644
--- a/testing/PRESUBMIT.py
+++ b/testing/buildbot/PRESUBMIT.py
@@ -2,7 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-"""Top-level presubmit script for testing.
+"""Enforces json format.
See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
for more details on the presubmit API built into depot_tools.
@@ -10,11 +10,10 @@ for more details on the presubmit API built into depot_tools.
def CommonChecks(input_api, output_api):
- output = []
- blacklist = [r'gmock.*', r'gtest.*']
- output.extend(input_api.canned_checks.RunPylint(
- input_api, output_api, black_list=blacklist))
- return output
+ args = [input_api.python_executable, 'manage.py', '--check']
+ cmd = input_api.Command(
+ name='manage', cmd=args, kwargs={}, message=output_api.PresubmitError)
+ return input_api.RunTests([cmd])
def CheckChangeOnUpload(input_api, output_api):
« no previous file with comments | « testing/android/native_test_util.cc ('k') | testing/buildbot/chromium.chrome.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698