mojo/tools/roll/build_v8.patch - Issue 1108173002: Roll //build, //native_client, and a few more targets of opportunity.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/tools/roll/build_v8.patch

Issue 1108173002: Roll //build, //native_client, and a few more targets of opportunity. Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 diff --git a/build/module_args/v8.gni b/build/module_args/v8.gni	1 diff --git a/build/module_args/v8.gni b/build/module_args/v8.gni

2 index df6a4a3..05b673b 100644	2 index db4ee4e..05b673b 100644

3 --- a/build/module_args/v8.gni	3 --- a/build/module_args/v8.gni

4 +++ b/build/module_args/v8.gni	4 +++ b/build/module_args/v8.gni

5 @@ -9,5 +9,7 @@ if (is_android) {	5 @@ -9,4 +9,7 @@ if (is_android) {

6 # TODO(sky): nuke this. Temporary while sorting out http://crbug.com/465456.	6 # TODO(sky): nuke this. Temporary while sorting out http://crbug.com/465456.

7 enable_correct_v8_arch = false	7 enable_correct_v8_arch = false

8	8

9 -v8_use_external_startup_data =	9 -v8_use_external_startup_data = !(is_chromeos \|\| is_win)

10 - !((is_android && is_android_webview_build) \|\| is_chromeos \|\| is_win)

11 +# Many V8 users in mojo do not support external startup data for V8, so	10 +# Many V8 users in mojo do not support external startup data for V8, so

12 +# we disable it. If enabled, special care should be taken to ensure the	11 +# we disable it. If enabled, special care should be taken to ensure the

13 +# appropriate startup data is correctly bundled for apps.	12 +# appropriate startup data is correctly bundled for apps.

14 +v8_use_external_startup_data = false	13 +v8_use_external_startup_data = false

OLD	NEW