Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1108133004: cr: Pass absolute path to output directory to gn (Closed)

Created:
5 years, 8 months ago by Sami
Modified:
5 years, 8 months ago
Reviewers:
petrcermak
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cr: Pass absolute path to output directory to gn This ensures 'cr prepare' does the right thing even if run in a subdirectory of src/. Committed: https://crrev.com/791d0d35e5dbb03974567d4443f1bc8b52ba5aa0 Cr-Commit-Position: refs/heads/master@{#327265}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Foiled again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M tools/cr/cr/actions/gn.py View 1 2 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Sami
5 years, 8 months ago (2015-04-28 11:06:09 UTC) #2
petrcermak
LGTM with 2 comments. Almost :-) Thanks, Petr https://codereview.chromium.org/1108133004/diff/1/tools/cr/cr/actions/gn.py File tools/cr/cr/actions/gn.py (right): https://codereview.chromium.org/1108133004/diff/1/tools/cr/cr/actions/gn.py#newcode59 tools/cr/cr/actions/gn.py:59: cr.context['CR_OUT_FULL']) ...
5 years, 8 months ago (2015-04-28 11:10:18 UTC) #3
Sami
Thanks. Looks like I still need to go smaller :) https://codereview.chromium.org/1108133004/diff/1/tools/cr/cr/actions/gn.py File tools/cr/cr/actions/gn.py (right): https://codereview.chromium.org/1108133004/diff/1/tools/cr/cr/actions/gn.py#newcode59 ...
5 years, 8 months ago (2015-04-28 11:15:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108133004/20001
5 years, 8 months ago (2015-04-28 11:15:34 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-28 11:29:30 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-28 11:30:26 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/791d0d35e5dbb03974567d4443f1bc8b52ba5aa0
Cr-Commit-Position: refs/heads/master@{#327265}

Powered by Google App Engine
This is Rietveld 408576698