Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1108133002: Converted some extension browser tests into using event pages (Closed)

Created:
5 years, 7 months ago by oystein (OOO til 10th of July)
Modified:
5 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Converted some extension browser tests into using event pages, to fix some timeout issues when background pages have their DOM timers throttled. R=kalman BUG= Committed: https://crrev.com/1dc63af0201f5429133b814be52aab24f8d71f16 Cr-Commit-Position: refs/heads/master@{#332059}

Patch Set 1 : #

Messages

Total messages: 19 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108133002/40001
5 years, 7 months ago (2015-05-27 18:38:18 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-05-27 19:43:32 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108133002/60001
5 years, 6 months ago (2015-05-29 17:49:24 UTC) #10
oystein (OOO til 10th of July)
kalman: This seems to be needed to be able to flip this thing on, or ...
5 years, 6 months ago (2015-05-29 17:49:58 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-05-29 19:59:54 UTC) #13
not at google - send to devlin
lgtm
5 years, 6 months ago (2015-05-29 22:07:33 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108133002/60001
5 years, 6 months ago (2015-05-29 22:10:16 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:60001)
5 years, 6 months ago (2015-05-29 22:16:58 UTC) #17
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1dc63af0201f5429133b814be52aab24f8d71f16 Cr-Commit-Position: refs/heads/master@{#332059}
5 years, 6 months ago (2015-05-29 22:18:31 UTC) #18
zhaoqin
5 years, 6 months ago (2015-06-01 03:36:28 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:60001) has been created in
https://codereview.chromium.org/1159593004/ by zhaoqin@google.com.

The reason for reverting is: browser_tests ExtensionApiTest.AutotestPrivate
failed on MSan bot

BUG=494815.

Powered by Google App Engine
This is Rietveld 408576698