Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Issue 1108083003: Re-land Move ScopedFileDescriptor to dbus/file_descriptor.h (Closed)

Created:
5 years, 8 months ago by Chris Masone
Modified:
5 years, 8 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land Move ScopedFileDescriptor to dbus/file_descriptor.h ScopedFileDescriptor was initially introduced to facilitate the management of a 'lifeline' FD used when asking permission_broker to open a port in the device's firewall on CrOS. It's actually a scoped wrapper around DBus::FileDescriptor, not a platform file descriptor. I would like to use it to facilitate some other similar functionality in which I create a pipe and pass one end over DBus, so it seems like a good idea to move ScopedFileDescriptor into the dbus library directly. This reverts commit ee9dc849ffa2df2820381c31d5ba8200774d287a. BUG=chromium:481340 TEST=FirewallHole unit tests still pass TBR=stevenjb, reillyg, keybuk Committed: https://crrev.com/610c3173c4dc2258c10c8b211ab9cbe21f2a1402 Cr-Commit-Position: refs/heads/master@{#327141}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -31 lines) Patch
M chromeos/network/firewall_hole.h View 3 chunks +6 lines, -17 lines 0 comments Download
M chromeos/network/firewall_hole.cc View 5 chunks +7 lines, -14 lines 0 comments Download
M dbus/file_descriptor.h View 3 chunks +10 lines, -0 lines 0 comments Download
M dbus/file_descriptor.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Chris Masone
While I'm trying to validate this locally, can you do me a solid and test ...
5 years, 8 months ago (2015-04-27 20:28:17 UTC) #2
Chris Masone
ok, I've verified that this works in the component build locally. Since the change was ...
5 years, 8 months ago (2015-04-27 20:35:37 UTC) #4
spang
tested & lgtm. Thank you!
5 years, 8 months ago (2015-04-27 20:46:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108083003/1
5 years, 8 months ago (2015-04-27 21:36:28 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 21:41:43 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 21:42:40 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/610c3173c4dc2258c10c8b211ab9cbe21f2a1402
Cr-Commit-Position: refs/heads/master@{#327141}

Powered by Google App Engine
This is Rietveld 408576698