Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: storage/browser/blob/blob_data_item.cc

Issue 1108083002: Create blobs from Disk Cache entries. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: omg, fix the correct base::Unretained... Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: storage/browser/blob/blob_data_item.cc
diff --git a/storage/browser/blob/blob_data_item.cc b/storage/browser/blob/blob_data_item.cc
index 504a1c3e8be39939d58c0ac19702f7c6d3e2ac89..c1ec3b3db68fadb7930d5cdcb022610cbb924037 100644
--- a/storage/browser/blob/blob_data_item.cc
+++ b/storage/browser/blob/blob_data_item.cc
@@ -6,12 +6,33 @@
namespace storage {
+BlobDataItem::DataHandle::~DataHandle() {
+}
+
+BlobDataItem::BlobDataItem(scoped_ptr<DataElement> item)
+ : item_(item.Pass()),
+ disk_cache_entry_(nullptr),
+ disk_cache_stream_index_(-1) {
+}
+
BlobDataItem::BlobDataItem(scoped_ptr<DataElement> item,
- scoped_refptr<ShareableFileReference> file_handle)
- : item_(item.Pass()), file_handle_(file_handle) {
+ const scoped_refptr<DataHandle>& data_handle)
+ : item_(item.Pass()),
+ data_handle_(data_handle),
+ disk_cache_entry_(nullptr),
+ disk_cache_stream_index_(-1) {
}
-BlobDataItem::BlobDataItem(scoped_ptr<DataElement> item) : item_(item.Pass()) {
+
+BlobDataItem::BlobDataItem(scoped_ptr<DataElement> item,
mmenke 2015/06/17 19:11:16 What's the conceptual distinction between a BlobDa
dmurph 2015/06/17 20:18:06 DataElement is legacy and is used in other parts o
+ const scoped_refptr<DataHandle>& data_handle,
+ disk_cache::Entry* entry,
+ int disk_cache_stream_index)
+ : item_(item.Pass()),
+ data_handle_(data_handle),
+ disk_cache_entry_(entry),
+ disk_cache_stream_index_(disk_cache_stream_index) {
}
+
BlobDataItem::~BlobDataItem() {
}

Powered by Google App Engine
This is Rietveld 408576698