Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1405)

Unified Diff: net/base/upload_bytes_element_reader.h

Issue 1108083002: Create blobs from Disk Cache entries. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: omg, fix the correct base::Unretained... Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/upload_bytes_element_reader.h
diff --git a/net/base/upload_bytes_element_reader.h b/net/base/upload_bytes_element_reader.h
index 4864c9ab6221279f92ead6c84899b2c871f687f7..e251e1451f87e3bb50c37df203770958488c5855 100644
--- a/net/base/upload_bytes_element_reader.h
+++ b/net/base/upload_bytes_element_reader.h
@@ -10,13 +10,14 @@
#include "base/basictypes.h"
#include "base/compiler_specific.h"
+#include "net/base/net_export.h"
#include "net/base/upload_element_reader.h"
namespace net {
-// An UploadElementReader implementation for bytes.
-// |data| should outlive this class because this class does not take the
-// ownership of the data.
+// An UploadElementReader implementation for bytes. The caller keeps ownership
+// of |data|, and is responsible for ensuring it outlives the
mmenke 2015/06/17 19:11:16 While you're here, |data| -> |bytes|?
gavinp 2015/06/18 18:50:55 Done. Also edited slightly for prettier justificat
+// UploadBytesElementReader.
class NET_EXPORT UploadBytesElementReader : public UploadElementReader {
public:
UploadBytesElementReader(const char* bytes, uint64_t length);

Powered by Google App Engine
This is Rietveld 408576698