content/browser/loader/upload_data_stream_builder.cc - Issue 1108083002: Create blobs from Disk Cache entries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/upload_data_stream_builder.cc

Issue 1108083002: Create blobs from Disk Cache entries. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: first pass michaeln remediation... Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/loader/upload_data_stream_builder.cc

diff --git a/content/browser/loader/upload_data_stream_builder.cc b/content/browser/loader/upload_data_stream_builder.cc

index c497c16c0a769ea50c20469ba1fc44e47708dc31..4620152953d4600161863b28dd10e9de51638066 100644

--- a/content/browser/loader/upload_data_stream_builder.cc

+++ b/content/browser/loader/upload_data_stream_builder.cc

@@ -135,6 +135,10 @@ scoped_ptr<net::UploadDataStream> UploadDataStreamBuilder::Build(

// TODO(dmurph): Create blob reader and store the snapshot in there.

NOTREACHED();

break;

+ case ResourceRequestBody::Element::TYPE_DISK_CACHE_ENTRY:

+ // TODO(gavinp): Implement upload for disk cache entry backed blobs.

+ NOTREACHED();

+ break;

case ResourceRequestBody::Element::TYPE_UNKNOWN:

NOTREACHED();

break;