Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1612)

Unified Diff: storage/browser/blob/view_blob_internals_job.cc

Issue 1108083002: Create blobs from Disk Cache entries. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased to upstream CL, review this upload Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: storage/browser/blob/view_blob_internals_job.cc
diff --git a/storage/browser/blob/view_blob_internals_job.cc b/storage/browser/blob/view_blob_internals_job.cc
index fff9c45ea8792d249305dd8cb9581452a678ba9e..e8ab795a010d104fe7599b048532f00510967f3b 100644
--- a/storage/browser/blob/view_blob_internals_job.cc
+++ b/storage/browser/blob/view_blob_internals_job.cc
@@ -206,9 +206,6 @@ void ViewBlobInternalsJob::GenerateHTMLForBlobData(
out);
}
break;
- case DataElement::TYPE_BLOB:
- NOTREACHED(); // Should be flattened in the storage context.
- break;
case DataElement::TYPE_FILE_FILESYSTEM:
AddHTMLListItem(kType, "filesystem", out);
AddHTMLListItem(kURL, item.filesystem_url().spec(), out);
@@ -218,6 +215,12 @@ void ViewBlobInternalsJob::GenerateHTMLForBlobData(
out);
}
break;
+ case DataElement::TYPE_DISK_CACHE_ENTRY:
+ AddHTMLListItem(kType, "disk cache entry", out);
+ AddHTMLListItem(kURL, item.disk_cache_entry()->GetKey(), out);
+ break;
jkarlin 2015/05/29 14:59:42 Please add NOTREACHED(); to this and TYPE_BLOB
gavinp 2015/05/29 18:06:07 Done.
+ case DataElement::TYPE_BLOB:
+ // Should be flattened in the storage context.
case DataElement::TYPE_UNKNOWN:
NOTREACHED();
break;

Powered by Google App Engine
This is Rietveld 408576698