Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1360)

Unified Diff: storage/browser/blob/view_blob_internals_job.cc

Issue 1108083002: Create blobs from Disk Cache entries. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: storage/browser/blob/view_blob_internals_job.cc
diff --git a/storage/browser/blob/view_blob_internals_job.cc b/storage/browser/blob/view_blob_internals_job.cc
index ab1f310d09edc0b4b866d73ddcf5599d2366916d..ddc1f441b3d72df8a093d39de7bfdae66463f9b9 100644
--- a/storage/browser/blob/view_blob_internals_job.cc
+++ b/storage/browser/blob/view_blob_internals_job.cc
@@ -206,9 +206,6 @@ void ViewBlobInternalsJob::GenerateHTMLForBlobData(
out);
}
break;
- case DataElement::TYPE_BLOB:
- NOTREACHED(); // Should be flattened in the storage context.
- break;
case DataElement::TYPE_FILE_FILESYSTEM:
AddHTMLListItem(kType, "filesystem", out);
AddHTMLListItem(kURL, item.filesystem_url().spec(), out);
@@ -218,6 +215,8 @@ void ViewBlobInternalsJob::GenerateHTMLForBlobData(
out);
}
break;
+ case DataElement::TYPE_BLOB: // Should be flattened in the storage context.
+ case DataElement::TYPE_DISK_CACHE_ENTRY: // XYZZY wot to do here yo?
case DataElement::TYPE_UNKNOWN:
NOTREACHED();
break;

Powered by Google App Engine
This is Rietveld 408576698