net/base/upload_element_reader.cc - Issue 1108083002: Create blobs from Disk Cache entries.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/base/upload_element_reader.cc

Issue 1108083002: Create blobs from Disk Cache entries. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: omg, fix the correct base::Unretained... Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« net/base/upload_disk_cache_entry_element_reader_unittest.cc ('K') | « net/base/upload_element_reader.h ('k') | net/base/upload_file_element_reader.h » ('j') | storage/browser/blob/blob_data_item.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "net/base/upload_element_reader.h"	5 #include "net/base/upload_element_reader.h"

6	6

7 namespace net {	7 namespace net {

8	8

	9 const UploadDiskCacheEntryElementReader*

	10 UploadElementReader::AsDiskCacheEntryReaderForTests() const {

	11 return nullptr;

	12 }

	13

9 const UploadBytesElementReader* UploadElementReader::AsBytesReader() const {	14 const UploadBytesElementReader* UploadElementReader::AsBytesReader() const {

10 return NULL;	15 return NULL;
	mmenke 2015/06/17 19:11:16 optional: Suggest updating these to nullptrs, whi optional: Suggest updating these to nullptrs, while you're here, for consistency. gavinp 2015/06/18 18:50:55 Done. Show quoted text On 2015/06/17 19:11:16, mmenke wrote: > optional: Suggest updating these to nullptrs, while you're here, for > consistency. Done.
11 }	16 }

12	17

13 const UploadFileElementReader* UploadElementReader::AsFileReader() const {	18 const UploadFileElementReader* UploadElementReader::AsFileReader() const {

14 return NULL;	19 return NULL;

15 }	20 }

16	21

17 bool UploadElementReader::IsInMemory() const {	22 bool UploadElementReader::IsInMemory() const {

18 return false;	23 return false;

19 }	24 }

20	25

21 } // namespace net	26 } // namespace net

OLD	NEW