Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1795)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1108053004: Add dash lines batch unit test (Closed)

Created:
5 years, 7 months ago by joshua.litt
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@randbatch1
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add dash lines batch unit test BUG=skia: Committed: https://skia.googlesource.com/skia/+/fa2008ff6ee5963fc2566b20c1af39367b77bdf7

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Total comments: 1

Patch Set 5 : tweaks #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -12 lines) Patch
M include/gpu/GrTestUtils.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrStrokeInfo.h View 1 2 2 chunks +18 lines, -1 line 0 comments Download
M src/gpu/GrTestUtils.cpp View 1 2 1 chunk +26 lines, -0 lines 1 comment Download
M src/gpu/effects/GrDashingEffect.cpp View 1 2 3 4 7 chunks +102 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
joshualitt
This actually doesn't compile because I actually can't include SkDashPathEffect.h from src/gpu. Thoughts?
5 years, 7 months ago (2015-04-29 14:49:01 UTC) #2
joshualitt
okay, this should be good now, ptal.
5 years, 7 months ago (2015-04-29 16:56:18 UTC) #3
bsalomon
lgtm
5 years, 7 months ago (2015-04-29 18:12:29 UTC) #4
egdaniel
https://codereview.chromium.org/1108053004/diff/60001/src/gpu/effects/GrDashingEffect.cpp File src/gpu/effects/GrDashingEffect.cpp (right): https://codereview.chromium.org/1108053004/diff/60001/src/gpu/effects/GrDashingEffect.cpp#newcode1356 src/gpu/effects/GrDashingEffect.cpp:1356: p.setStrokeCap(SkPaint::kRound_Cap); Can only do round caps if on interval ...
5 years, 7 months ago (2015-04-29 18:17:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108053004/80001
5 years, 7 months ago (2015-04-29 18:27:09 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://skia.googlesource.com/skia/+/fa2008ff6ee5963fc2566b20c1af39367b77bdf7
5 years, 7 months ago (2015-04-29 18:32:09 UTC) #9
brucedawson
5 years, 7 months ago (2015-04-30 20:19:06 UTC) #11
Message was sent while issue was closed. 
https://codereview.chromium.org/1108053004/diff/80001/src/gpu/GrTestUtils.cpp
File src/gpu/GrTestUtils.cpp (right):

https://codereview.chromium.org/1108053004/diff/80001/src/gpu/GrTestUtils.cpp...
src/gpu/GrTestUtils.cpp:48: gMatrices[4].setRotate(47);
These three lines of code reference gMatrices[4] but the last legal offset is
gMatrices[3]. This was detected through a /analyze warning that said:

third_party\skia\src\gpu\grtestutils.cpp(46) : warning C6200: Index '4' is out
of valid index range '0' to '3' for non-stack buffer 'class SkMatrix * `class
SkMatrix const & __cdecl GrTest::TestMatrixPreservesRightAngles(class SkRandom
*)'::`2'::gMatrices'.

Powered by Google App Engine
This is Rietveld 408576698