Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 1108053003: Fix gaia logout URLFetcher memory leak (Closed)

Created:
5 years, 7 months ago by dtapuska
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix gaia logout URLFetcher memory leak Store the gaia logout url request so the URLFetcher object isn't leaked. BUG=482459 TEST=google_api_unittests Committed: https://crrev.com/1162a2e5e6439ff065910fec67f7919034841b9c Cr-Commit-Position: refs/heads/master@{#327500}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M components/signin/core/browser/gaia_cookie_manager_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/signin/core/browser/gaia_cookie_manager_service.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dtapuska
5 years, 7 months ago (2015-04-29 14:24:42 UTC) #2
Mike Lerman
Thanks for sending out a patch to fix this :) (non-owner) lgtm
5 years, 7 months ago (2015-04-29 14:41:37 UTC) #3
Roger Tawa OOO till Jul 10th
lgtm
5 years, 7 months ago (2015-04-29 15:13:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108053003/1
5 years, 7 months ago (2015-04-29 15:23:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 16:03:47 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 16:04:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1162a2e5e6439ff065910fec67f7919034841b9c
Cr-Commit-Position: refs/heads/master@{#327500}

Powered by Google App Engine
This is Rietveld 408576698