Fix "mouse" position selection in svg/text/resources/SelectionTestCase.js

Fix "mouse" position selection in svg/text/resources/SelectionTestCase.js

eventSender.mouseMoveTo(...) truncates the coordinates it is passed, so
fractional coordinates could end being adjust by almost an entire pixel,
which could yield incorrect results.
Round the end-points such that they should reside within the intended
selection area.

BUG=477545
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194604

[fs, 2015-04-27 19:00:00]

fs@opera.com changed reviewers:
+ pdr@chromium.org

[fs, 2015-04-27 19:00:01]

Maybe with this we can make progress in that other review...

[pdr., 2015-04-27 20:01:38]

LGTM

[hyunjunekim2, 2015-04-28 02:22:06]

hyunjune.kim@samsung.com changed reviewers:
+ hyunjune.kim@samsung.com

[hyunjunekim2, 2015-04-28 02:22:07]

https://codereview.chromium.org/1108033002/diff/1/LayoutTests/svg/text/resour...
File LayoutTests/svg/text/resources/SelectionTestCase.js (right):

https://codereview.chromium.org/1108033002/diff/1/LayoutTests/svg/text/resour...
LayoutTests/svg/text/resources/SelectionTestCase.js:74: absStartPos.x =
Math.ceil(absStartPos.x);
Could you change like this?
absStartPos.x = Math.ceil(absStartPos.x) + 4;

[pdr., 2015-04-28 03:08:39]

https://codereview.chromium.org/1108033002/diff/1/LayoutTests/svg/text/resour...
File LayoutTests/svg/text/resources/SelectionTestCase.js (right):

https://codereview.chromium.org/1108033002/diff/1/LayoutTests/svg/text/resour...
LayoutTests/svg/text/resources/SelectionTestCase.js:74: absStartPos.x =
Math.ceil(absStartPos.x);
On 2015/04/28 at 02:22:07, hyunjunekim2 wrote:
> Could you change like this?
> absStartPos.x = Math.ceil(absStartPos.x) + 4;

Why?

[hyunjunekim2, 2015-04-28 05:31:41]

On 2015/04/28 03:08:39, pdr wrote:
>
https://codereview.chromium.org/1108033002/diff/1/LayoutTests/svg/text/resour...
> File LayoutTests/svg/text/resources/SelectionTestCase.js (right):
> 
>
https://codereview.chromium.org/1108033002/diff/1/LayoutTests/svg/text/resour...
> LayoutTests/svg/text/resources/SelectionTestCase.js:74: absStartPos.x =
> Math.ceil(absStartPos.x);
> On 2015/04/28 at 02:22:07, hyunjunekim2 wrote:
> > Could you change like this?
> > absStartPos.x = Math.ceil(absStartPos.x) + 4;
> 
> Why?
pdr, fs,
In https://codereview.chromium.org/1072403007/, i updated PS 19 was removed
|floor|, but occur to fail on this test case
base on Ubuntu. So I suggest this one for getting some advises.

[pdr., 2015-04-28 05:34:35]

On 2015/04/28 at 05:31:41, hyunjune.kim wrote:
> On 2015/04/28 03:08:39, pdr wrote:
> >
https://codereview.chromium.org/1108033002/diff/1/LayoutTests/svg/text/resour...
> > File LayoutTests/svg/text/resources/SelectionTestCase.js (right):
> > 
> >
https://codereview.chromium.org/1108033002/diff/1/LayoutTests/svg/text/resour...
> > LayoutTests/svg/text/resources/SelectionTestCase.js:74: absStartPos.x =
> > Math.ceil(absStartPos.x);
> > On 2015/04/28 at 02:22:07, hyunjunekim2 wrote:
> > > Could you change like this?
> > > absStartPos.x = Math.ceil(absStartPos.x) + 4;
> > 
> > Why?
> pdr, fs,
> In https://codereview.chromium.org/1072403007/, i updated PS 19 was removed
|floor|, but occur to fail on this test case
> base on Ubuntu. So I suggest this one for getting some advises.

I was just wondering why you chose "+ 4". Where does 4 come from?

[hyunjunekim2, 2015-04-28 05:37:55]

On 2015/04/28 05:34:35, pdr wrote:
> On 2015/04/28 at 05:31:41, hyunjune.kim wrote:
> > On 2015/04/28 03:08:39, pdr wrote:
> > >
>
https://codereview.chromium.org/1108033002/diff/1/LayoutTests/svg/text/resour...
> > > File LayoutTests/svg/text/resources/SelectionTestCase.js (right):
> > > 
> > >
>
https://codereview.chromium.org/1108033002/diff/1/LayoutTests/svg/text/resour...
> > > LayoutTests/svg/text/resources/SelectionTestCase.js:74: absStartPos.x =
> > > Math.ceil(absStartPos.x);
> > > On 2015/04/28 at 02:22:07, hyunjunekim2 wrote:
> > > > Could you change like this?
> > > > absStartPos.x = Math.ceil(absStartPos.x) + 4;
> > > 
> > > Why?
> > pdr, fs,
> > In https://codereview.chromium.org/1072403007/, i updated PS 19 was removed
> |floor|, but occur to fail on this test case
> > base on Ubuntu. So I suggest this one for getting some advises.
> 
> I was just wondering why you chose "+ 4". Where does 4 come from?

pdr, Sorry, this is experimental. If select "+ 3", occur to fail.

[fs, 2015-04-28 14:34:02]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2015-04-28 14:34:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1108033002/1

[commit-bot: I haz the power, 2015-04-28 14:37:33]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194604