Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1108023002: Pass mojo_shell args to child processes. (Closed)

Created:
5 years, 8 months ago by jam
Modified:
5 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass mojo_shell args to child processes. This allows URL(s) sent as args to be passed to the window manager. Also send --override-use-gl-with-osmesa-for-tests since it's listed on the sites page. Committed: https://crrev.com/b8c01014e526dabbc1af9505bd8e5cbd0500582e Cr-Commit-Position: refs/heads/master@{#327056}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M mojo/shell/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/shell/child_process_host.cc View 3 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jam
5 years, 8 months ago (2015-04-27 16:18:06 UTC) #2
sky
LGTM
5 years, 8 months ago (2015-04-27 16:40:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108023002/1
5 years, 8 months ago (2015-04-27 16:44:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 16:48:51 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 16:51:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b8c01014e526dabbc1af9505bd8e5cbd0500582e
Cr-Commit-Position: refs/heads/master@{#327056}

Powered by Google App Engine
This is Rietveld 408576698