Make Skia for Android libjpeg use ashmem

Make Skia for Android libjpeg use ashmem

BUG=skia:1282
Committed: https://skia.googlesource.com/skia/+/a3a8eb6f630c5e163ce45503b970ea993737780d

[msarett, 2015-04-27 16:01:56]

msarett@google.com changed reviewers:
+ djsollen@google.com, scroggo@google.com

[msarett, 2015-04-27 16:01:57]

Jpeg tests are passing using ashmem.

If this looks good and we land it, I will update Android to always use ashmem as
well.

So far, it looks like using ashmem fixes skia bug 1282.  However, it is not
completely clear that we will avoid this bug in all cases.  This will be
investigated further.

https://codereview.chromium.org/1108013002/diff/1/platform_tools/android/gyp/...
File platform_tools/android/gyp/dependencies.gypi (right):

https://codereview.chromium.org/1108013002/diff/1/platform_tools/android/gyp/...
platform_tools/android/gyp/dependencies.gypi:42:
'../third_party/cutils/ashmem-dev.c'
Directory is named cutils so we can avoid making local modifications to
jmem-ashmem.c

[djsollen, 2015-04-27 17:12:25]

https://codereview.chromium.org/1108013002/diff/1/platform_tools/android/gyp/...
File platform_tools/android/gyp/dependencies.gypi (right):

https://codereview.chromium.org/1108013002/diff/1/platform_tools/android/gyp/...
platform_tools/android/gyp/dependencies.gypi:41:
'../third_party/cutils/ashmem.h',
let's put this code into...

../third_party/ashmem/cutils/ashmem.h so that it is clear in the directory
structure what this is.

https://codereview.chromium.org/1108013002/diff/1/platform_tools/android/gyp/...
platform_tools/android/gyp/dependencies.gypi:43: ],
add 

'direct_dependent_settings': {
  'include_dirs': [
    '../third_party/ashmem',
  ]
},

https://codereview.chromium.org/1108013002/diff/1/platform_tools/android/gyp/...
platform_tools/android/gyp/dependencies.gypi:201: '../third_party/',
remove this

https://codereview.chromium.org/1108013002/diff/1/platform_tools/android/thir...
File platform_tools/android/third_party/cutils/OWNERS (right):

https://codereview.chromium.org/1108013002/diff/1/platform_tools/android/thir...
platform_tools/android/third_party/cutils/OWNERS:1: digit@chromium.org
remove this owners file.

[msarett, 2015-04-27 17:31:02]

Patchset #2 (id:20001) has been deleted

[msarett, 2015-04-27 17:32:49]

https://codereview.chromium.org/1108013002/diff/1/platform_tools/android/gyp/...
File platform_tools/android/gyp/dependencies.gypi (right):

https://codereview.chromium.org/1108013002/diff/1/platform_tools/android/gyp/...
platform_tools/android/gyp/dependencies.gypi:41:
'../third_party/cutils/ashmem.h',
On 2015/04/27 17:12:25, djsollen wrote:
> let's put this code into...
> 
> ../third_party/ashmem/cutils/ashmem.h so that it is clear in the directory
> structure what this is.

Done.

https://codereview.chromium.org/1108013002/diff/1/platform_tools/android/gyp/...
platform_tools/android/gyp/dependencies.gypi:43: ],
On 2015/04/27 17:12:25, djsollen wrote:
> add 
> 
> 'direct_dependent_settings': {
>   'include_dirs': [
>     '../third_party/ashmem',
>   ]
> },

Done.

https://codereview.chromium.org/1108013002/diff/1/platform_tools/android/gyp/...
platform_tools/android/gyp/dependencies.gypi:201: '../third_party/',
On 2015/04/27 17:12:25, djsollen wrote:
> remove this

Done.

https://codereview.chromium.org/1108013002/diff/1/platform_tools/android/thir...
File platform_tools/android/third_party/cutils/OWNERS (right):

https://codereview.chromium.org/1108013002/diff/1/platform_tools/android/thir...
platform_tools/android/third_party/cutils/OWNERS:1: digit@chromium.org
On 2015/04/27 17:12:25, djsollen wrote:
> remove this owners file.

Done.

[djsollen, 2015-04-27 17:36:05]

lgtm pending moving the license and README into the ashmem dir.

[msarett, 2015-04-27 17:40:08]

The CQ bit was checked by msarett@google.com

[msarett, 2015-04-27 17:40:08]

The patchset sent to the CQ was uploaded after l-g-t-m from djsollen@google.com
Link to the patchset: https://codereview.chromium.org/1108013002/#ps60001
(title: "Moving README and LICENSE up one dir")

[commit-bot: I haz the power, 2015-04-27 17:40:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1108013002/60001

[commit-bot: I haz the power, 2015-04-27 17:57:27]

Committed patchset #3 (id:60001) as
https://skia.googlesource.com/skia/+/a3a8eb6f630c5e163ce45503b970ea993737780d

[msarett, 2015-06-11 17:19:42]

Given that we made the choice to move to jmemnobs.c this change no longer makes
sense.

If we revert, however, we will be back to using jmem-android.c and skia bug 1282
will be reintroduced.

I think it's appropriate to wait on this until we update to Android's version of
libjpeg (hopefully turbo) that uses jmemnobs.c.

If we feel we need to switch sooner, I can also revert and then submit another
CL to switch us to jmemnobs.c.

[scroggo, 2015-06-11 17:40:17]

On 2015/06/11 17:19:42, msarett wrote:
> Given that we made the choice to move to jmemnobs.c this change no longer
makes
> sense.
> 
> If we revert, however, we will be back to using jmem-android.c and skia bug
1282
> will be reintroduced.
> 
> I think it's appropriate to wait on this until we update to Android's version
of
> libjpeg (hopefully turbo) that uses jmemnobs.c.
>
 
sgtm.