Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 1107993002: Make it possible to hoist the neutering check for TA property accesses (Closed)

Created:
5 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make it possible to hoist the neutering check for TA property accesses Also correctly set up the dependency between propoerty and elements accesses and the checks BUG=v8:3996 R=hpayer@chromium.org LOG=n Committed: https://crrev.com/6a62e321381e1a212983804c4197068e842b240f Cr-Commit-Position: refs/heads/master@{#28087}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M src/hydrogen.cc View 2 chunks +16 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
jochen (gone - plz use gerrit)
5 years, 8 months ago (2015-04-27 14:16:53 UTC) #1
Hannes Payer (out of office)
LGTM, do we have tests that stress that?
5 years, 8 months ago (2015-04-27 15:21:54 UTC) #2
jochen (gone - plz use gerrit)
On 2015/04/27 at 15:21:54, hpayer wrote: > LGTM, do we have tests that stress that? ...
5 years, 8 months ago (2015-04-27 15:27:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107993002/1
5 years, 8 months ago (2015-04-27 15:27:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 16:18:21 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6a62e321381e1a212983804c4197068e842b240f Cr-Commit-Position: refs/heads/master@{#28087}
5 years, 8 months ago (2015-04-27 16:18:35 UTC) #7
Michael Achenbach
5 years, 8 months ago (2015-04-27 16:56:11 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1108823003/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks benchmarks:
http://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/3403.

Powered by Google App Engine
This is Rietveld 408576698