Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1107923002: SkPDF: clean up uses of deprecated calls in other SkPDF classes (Closed)

Created:
5 years, 8 months ago by hal.canary
Modified:
5 years, 7 months ago
Reviewers:
tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: clean up uses of deprecated calls in other SkPDF classes BUG=skia:3585 Committed: https://skia.googlesource.com/skia/+/a25b3371a7209105e6c05f7bbb53d19e2b14498b

Patch Set 1 : 2015-04-27 (Monday) 09:04:15 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -34 lines) Patch
M src/pdf/SkPDFBitmap.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M src/pdf/SkPDFFormXObject.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M src/pdf/SkPDFGraphicState.cpp View 4 chunks +9 lines, -10 lines 0 comments Download
M src/pdf/SkPDFShader.cpp View 3 chunks +10 lines, -12 lines 0 comments Download
M src/pdf/SkPDFTypes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/pdf/SkPDFTypes.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107923002/1
5 years, 8 months ago (2015-04-27 12:28:45 UTC) #2
hal.canary
PTAL
5 years, 8 months ago (2015-04-27 12:28:48 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/525) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on ...
5 years, 8 months ago (2015-04-27 12:30:47 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107923002/20001
5 years, 8 months ago (2015-04-27 13:04:39 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-27 13:07:29 UTC) #10
tomhudson
lgtm
5 years, 7 months ago (2015-04-27 20:36:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107923002/20001
5 years, 7 months ago (2015-04-27 20:57:34 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-04-27 21:00:12 UTC) #15
Message was sent while issue was closed. 
Committed patchset #1 (id:20001) as
https://skia.googlesource.com/skia/+/a25b3371a7209105e6c05f7bbb53d19e2b14498b

Powered by Google App Engine
This is Rietveld 408576698