Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: net/http/http_content_disposition.h

Issue 1107913003: Remove support for "name" parameter from Content-Disposition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adjust comment for clarity Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/filename_util_unittest.cc ('k') | net/http/http_content_disposition.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_content_disposition.h
diff --git a/net/http/http_content_disposition.h b/net/http/http_content_disposition.h
index 2b4ca709eb3cbb581bab6c9101eda889fc0a3141..c96ba6186034b558a1c0d20104396290df7f6507 100644
--- a/net/http/http_content_disposition.h
+++ b/net/http/http_content_disposition.h
@@ -19,7 +19,9 @@ class NET_EXPORT HttpContentDisposition {
ATTACHMENT,
};
- // Properties of the Content-Disposition header. Used for UMA.
+ // Properties of the Content-Disposition header. These flags are used to
+ // report download metrics in UMA. This enum isn't directly used in UMA but
+ // mapped to another one for binary compatiblity; ie. changes are OK.
enum ParseResultFlags {
INVALID = 0,
@@ -29,25 +31,22 @@ class NET_EXPORT HttpContentDisposition {
// The disposition-type is not 'inline' or 'attachment'.
HAS_UNKNOWN_DISPOSITION_TYPE = 1 << 1,
- // Has a valid non-empty 'name' attribute.
- HAS_NAME = 1 << 2,
-
// Has a valid non-empty 'filename' attribute.
- HAS_FILENAME = 1 << 3,
+ HAS_FILENAME = 1 << 2,
// Has a valid non-empty 'filename*' attribute.
- HAS_EXT_FILENAME = 1 << 4,
+ HAS_EXT_FILENAME = 1 << 3,
// The following fields are properties of the 'filename' attribute:
// Quoted-string contains non-ASCII characters.
- HAS_NON_ASCII_STRINGS = 1 << 5,
+ HAS_NON_ASCII_STRINGS = 1 << 4,
// Quoted-string contains percent-encoding.
- HAS_PERCENT_ENCODED_STRINGS = 1 << 6,
+ HAS_PERCENT_ENCODED_STRINGS = 1 << 5,
// Quoted-string contains RFC 2047 encoded words.
- HAS_RFC2047_ENCODED_STRINGS = 1 << 7
+ HAS_RFC2047_ENCODED_STRINGS = 1 << 6
};
HttpContentDisposition(const std::string& header,
« no previous file with comments | « net/base/filename_util_unittest.cc ('k') | net/http/http_content_disposition.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698