Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 1107913003: Remove support for "name" parameter from Content-Disposition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adjust comment for clarity Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « net/http/http_content_disposition_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index ab123224f2860a2b8f78e77c1057028c1e7c0773..36ee9fa11633449f424c223a5c0c9d841effd36e 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -6131,8 +6131,8 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<owner>asanka@chromium.org</owner>
<summary>
Content-Disposition header features. The presence of a Content-Disposition
- header, use of 'name', 'filename' and 'filename*' parameters, and string
- encoding schemes are counted for each unthrottled download. The total number
+ header, use of 'filename' and 'filename*' parameters, and string encoding
+ schemes are counted for each unthrottled download. The total number
downloads is Download.Counts[5] (Initiated and Unthrottled).
</summary>
</histogram>
@@ -48851,13 +48851,13 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<int value="1" label="Valid"/>
<int value="2" label="Has disposition-type"/>
<int value="3" label="Has unknown disposition-type"/>
- <int value="4" label="Has 'name' attribute"/>
+ <int value="4" label="Has 'name' attribute (Obsolete 04/2015)"/>
<int value="5" label="Has 'filename' attribute"/>
<int value="6" label="Has 'filename*' attribute"/>
<int value="7" label="Has non-ASCII strings"/>
<int value="8" label="Has percent encoded strings"/>
<int value="9" label="Has RFC 2047 encoded strings"/>
- <int value="10" label="Has 'name' attribute only"/>
+ <int value="10" label="Has 'name' attribute only (Obsolete 04/2015)"/>
</enum>
<enum name="DownloadContentType" type="int">
« no previous file with comments | « net/http/http_content_disposition_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698