SkPDF: clean up uses of deprecated calls in SkDocument_PDF

SkPDF: clean up uses of deprecated calls in SkDocument_PDF

BUG=skia:3585
Committed: https://skia.googlesource.com/skia/+/72266fd1fe9bfe078239a9d9e85f479faee30281

[hal.canary, 2015-04-27 12:24:53]

halcanary@google.com changed reviewers:
+ tomhudson@google.com

[hal.canary, 2015-04-27 12:24:53]

PTAL

[hal.canary, 2015-04-27 12:25:08]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-04-27 12:25:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1107913002/1

[commit-bot: I haz the power, 2015-04-27 12:31:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-27 12:31:02]

Dry run: This issue passed the CQ dry run.

[hal.canary, 2015-05-01 11:47:34]

ping

[tomhudson, 2015-05-04 18:15:04]

lgtm

You gave me a great precis of how you want to do memory management a week or two
ago. Could you add that to https://skia.org/dev/design/pdftheory?

https://codereview.chromium.org/1107913002/diff/1/src/doc/SkDocument_PDF.cpp
File src/doc/SkDocument_PDF.cpp (right):

https://codereview.chromium.org/1107913002/diff/1/src/doc/SkDocument_PDF.cpp#...
src/doc/SkDocument_PDF.cpp:66: return SkNEW_ARGS(SkPDFStream, (content.get()));
Ugh, I really need to internalize your memory management approach.

We create content.
We store the pointer in the SkPDFStream
We then autodelete content?

... because two or three layers down in the calling chain,
SkStreamRewindableFromSkStream is going to try to duplicate the stream passed
in? Is there not a reasonable way to do this that isn't going to dup a stream?
(Or is that so lightweight it doesn't matter?)

[hal.canary, 2015-05-05 14:37:50]

https://codereview.chromium.org/1107913002/diff/1/src/doc/SkDocument_PDF.cpp
File src/doc/SkDocument_PDF.cpp (right):

https://codereview.chromium.org/1107913002/diff/1/src/doc/SkDocument_PDF.cpp#...
src/doc/SkDocument_PDF.cpp:66: return SkNEW_ARGS(SkPDFStream, (content.get()));
On 2015/05/04 18:15:04, tomhudson wrote:
> Ugh, I really need to internalize your memory management approach.
> 
> We create content.
> We store the pointer in the SkPDFStream
> We then autodelete content?
> 
> ... because two or three layers down in the calling chain,
> SkStreamRewindableFromSkStream is going to try to duplicate the stream passed
> in? Is there not a reasonable way to do this that isn't going to dup a stream?
> (Or is that so lightweight it doesn't matter?)

Yes.  SkStreamRewindableFromSkStream should be almost free.

Also, SkPDFStream will be re-written from scratch at a later date.

[hal.canary, 2015-05-05 14:37:55]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2015-05-05 14:38:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1107913002/1

[commit-bot: I haz the power, 2015-05-05 15:00:29]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/72266fd1fe9bfe078239a9d9e85f479faee30281