Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1107883002: [turbofan] Add language mode to JSCallFunction operator. (Closed)

Created:
5 years, 8 months ago by Benedikt Meurer
Modified:
5 years, 8 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add language mode to JSCallFunction operator. Also do some drive-by-cleanup to the unittests. R=svenpanne@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/2d827809e0a20fc60faa3be87ba9357bbded4a4c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -97 lines) Patch
M src/compiler/ast-graph-builder.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M src/compiler/js-operator.h View 2 chunks +28 lines, -11 lines 0 comments Download
M src/compiler/js-operator.cc View 2 chunks +4 lines, -20 lines 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 6 chunks +68 lines, -62 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Benedikt Meurer
5 years, 8 months ago (2015-04-27 10:27:27 UTC) #1
Benedikt Meurer
Hey Sven, As discussed offline, here's the language mode for JSCallFunction. Please take a look. ...
5 years, 8 months ago (2015-04-27 10:28:28 UTC) #2
Sven Panne
lgtm
5 years, 8 months ago (2015-04-27 10:38:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107883002/1
5 years, 8 months ago (2015-04-27 10:38:46 UTC) #5
Benedikt Meurer
Committed patchset #1 (id:1) manually as 2d827809e0a20fc60faa3be87ba9357bbded4a4c (presubmit successful).
5 years, 8 months ago (2015-04-27 10:45:12 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2d827809e0a20fc60faa3be87ba9357bbded4a4c Cr-Commit-Position: refs/heads/master@{#28066}
5 years, 8 months ago (2015-04-27 10:45:13 UTC) #7
Michael Achenbach
5 years, 8 months ago (2015-04-27 10:59:30 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1103143002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] breaks win compile and was committed
manually.

Powered by Google App Engine
This is Rietveld 408576698