Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 1107863002: [chrome/browser/profile_resetter] favor DCHECK_CURRENTLY_ON for better logs (Closed)

Created:
5 years, 8 months ago by anujsharma
Modified:
5 years, 8 months ago
Reviewers:
vasilii
CC:
chromium-reviews, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/profile_resetter BUG=466848 Committed: https://crrev.com/5893b13be4d92209bee3913e1bb0107815745312 Cr-Commit-Position: refs/heads/master@{#327250}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -37 lines) Patch
M chrome/browser/profile_resetter/automatic_profile_resetter.cc View 19 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/profile_resetter/automatic_profile_resetter_delegate.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/profile_resetter/profile_resetter.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/profile_resetter/profile_resetter_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profile_resetter/resettable_settings_snapshot.cc View 7 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
anujsharma
PTAL
5 years, 8 months ago (2015-04-27 10:48:00 UTC) #2
vasilii
lgtm
5 years, 8 months ago (2015-04-28 06:54:29 UTC) #3
anujsharma
On 2015/04/28 06:54:29, vasilii wrote: > lgtm Thanks vasilli for lgtm.
5 years, 8 months ago (2015-04-28 07:24:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107863002/1
5 years, 8 months ago (2015-04-28 07:24:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-28 09:22:51 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-28 09:23:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5893b13be4d92209bee3913e1bb0107815745312
Cr-Commit-Position: refs/heads/master@{#327250}

Powered by Google App Engine
This is Rietveld 408576698