sky/engine/web/WebViewImpl.cpp - Issue 1107853003: Fix up strings Sky passes to base/trace_event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/web/WebViewImpl.cpp

Issue 1107853003: Fix up strings Sky passes to base/trace_event (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/web/WebViewImpl.cpp

diff --git a/sky/engine/web/WebViewImpl.cpp b/sky/engine/web/WebViewImpl.cpp

index f62e9b4d794eb61aae4b26658af2324c81f0c258..342bd53d669941333e55d8b6bf7a87d318f1cf67 100644

--- a/sky/engine/web/WebViewImpl.cpp

+++ b/sky/engine/web/WebViewImpl.cpp

@@ -311,7 +311,8 @@ static String inputTypeToName(WebInputEvent::Type type)

bool WebViewImpl::handleInputEvent(const WebInputEvent& inputEvent)

{

- TRACE_EVENT1("input", "WebViewImpl::handleInputEvent", "type", inputTypeToName(inputEvent.type).ascii().data());

+ TRACE_EVENT1("input", "WebViewImpl::handleInputEvent", "type",

+ TRACE_STR_COPY(inputTypeToName(inputEvent.type).ascii().data()));

if (WebInputEvent::isPointerEventType(inputEvent.type)) {

const WebPointerEvent& event = static_cast<const WebPointerEvent&>(inputEvent);