sky/engine/core/fetch/ResourceFetcher.cpp - Issue 1107853003: Fix up strings Sky passes to base/trace_event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/fetch/ResourceFetcher.cpp

Issue 1107853003: Fix up strings Sky passes to base/trace_event (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sky/engine/core/events/GenericEventQueue.cpp ('K') | « sky/engine/core/events/GenericEventQueue.cpp ('k') | sky/engine/core/frame/Tracing.cpp » ('j') | sky/engine/core/frame/Tracing.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sky/engine/core/fetch/ResourceFetcher.cpp

diff --git a/sky/engine/core/fetch/ResourceFetcher.cpp b/sky/engine/core/fetch/ResourceFetcher.cpp

index 913482074e1aba1578c43757ed2cf7d4523f4a32..ec4ab7aac8b4127f077c41a8b46221ae4be1b19b 100644

--- a/sky/engine/core/fetch/ResourceFetcher.cpp

+++ b/sky/engine/core/fetch/ResourceFetcher.cpp

@@ -694,7 +694,10 @@ void ResourceFetcher::willTerminateResourceLoader(ResourceLoader* loader)

void ResourceFetcher::willStartLoadingResource(Resource* resource, ResourceRequest& request)

{

- TRACE_EVENT_ASYNC_BEGIN2("net", "Resource", resource, "url", resource->url().string().ascii().data(), "priority", resource->resourceRequest().priority());

+ TRACE_EVENT_ASYNC_BEGIN2(

+ "net", "Resource", resource, "url",

+ TRACE_STR_COPY(resource->url().string().ascii().data()), "priority",

jamesr 2015/04/29 00:12:46 same here

+ resource->resourceRequest().priority());

}

void ResourceFetcher::stopFetching()

« sky/engine/core/events/GenericEventQueue.cpp ('K') | « sky/engine/core/events/GenericEventQueue.cpp ('k') | sky/engine/core/frame/Tracing.cpp » ('j') | sky/engine/core/frame/Tracing.cpp » ('J')