Fix up strings Sky passes to base/trace_event

sky/engine/core/events/GenericEventQueue.cpp

 /*
  * Copyright (C) 2012 Victor Carbune (victor@rosedu.org)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 38 matching lines @@
 }
 
 bool GenericEventQueue::enqueueEvent(PassRefPtr<Event> event)
 {
     if (m_isClosed)
         return false;
 
     if (event->target() == m_owner)
         event->setTarget(nullptr);
 
-    TRACE_EVENT_ASYNC_BEGIN1("event", "GenericEventQueue:enqueueEvent", event.get(), "type", event->type().ascii().data());
+    TRACE_EVENT_ASYNC_BEGIN1("event", "GenericEventQueue:enqueueEvent",
+                             event.get(), "type",
+                             TRACE_STR_COPY(event->type().ascii().data()));

[jamesr, 2015/04/29 00:12:46]

event->type().ascii().data() is a pointer to temporary data that won't live past
the end of this function call, so it needs to be copied.

     m_pendingEvents.append(event);
 
     if (!m_timer.isActive())
         m_timer.startOneShot(0, FROM_HERE);
 
     return true;
 }
 
 bool GenericEventQueue::cancelEvent(Event* event)
 {
     bool found = m_pendingEvents.contains(event);
 
     if (found) {
         m_pendingEvents.remove(m_pendingEvents.find(event));
-        TRACE_EVENT_ASYNC_END2("event", "GenericEventQueue:enqueueEvent", event, "type", event->type().ascii().data(), "status", "cancelled");
+        TRACE_EVENT_ASYNC_END2("event", "GenericEventQueue:enqueueEvent", event,
+                               "type",
+                               TRACE_STR_COPY(event->type().ascii().data()),

[jamesr, 2015/04/29 00:12:46]

ditto

+                               "status", "cancelled");
     }
 
     if (m_pendingEvents.isEmpty())
         m_timer.stop();
 
     return found;
 }
 
 void GenericEventQueue::timerFired(Timer<GenericEventQueue>*)
 {
@@ skipping 19 matching lines @@
     m_isClosed = true;
     cancelAllEvents();
 }
 
 void GenericEventQueue::cancelAllEvents()
 {
     m_timer.stop();
 
     for (size_t i = 0; i < m_pendingEvents.size(); ++i) {
         Event* event = m_pendingEvents[i].get();
-        TRACE_EVENT_ASYNC_END2("event", "GenericEventQueue:enqueueEvent", event, "type", event->type().ascii().data(), "status", "cancelled");
+        TRACE_EVENT_ASYNC_END2("event", "GenericEventQueue:enqueueEvent", event,
+                               "type",
+                               TRACE_STR_COPY(event->type().ascii().data()),

[jamesr, 2015/04/29 00:12:46]

ditto

+                               "status", "cancelled");
     }
     m_pendingEvents.clear();
 }
 
 bool GenericEventQueue::hasPendingEvents() const
 {
     return m_pendingEvents.size();
 }
 
 }