Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1107853002: Handlify ExecutableAccessorInfo::ClearSetter since it allocates. (Closed)

Created:
5 years, 8 months ago by Toon Verwaest
Modified:
5 years, 8 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Handlify ExecutableAccessorInfo::ClearSetter since it allocates. BUG=chromium:478556 LOG=n Committed: https://crrev.com/a4b7d45c7b524acca070282c6ceeaf54e5ef4883 Cr-Commit-Position: refs/heads/master@{#28065}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
PTAL
5 years, 8 months ago (2015-04-27 09:19:29 UTC) #2
dcarney
lgtm
5 years, 8 months ago (2015-04-27 09:29:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107853002/1
5 years, 8 months ago (2015-04-27 09:30:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 10:18:55 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 10:19:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4b7d45c7b524acca070282c6ceeaf54e5ef4883
Cr-Commit-Position: refs/heads/master@{#28065}

Powered by Google App Engine
This is Rietveld 408576698