Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: src/heap/heap.h

Issue 1107843002: Reland "Remove the weak list of views from array buffers" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: use bounds check Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap-snapshot-generator.cc ('k') | src/heap/heap.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap.h
diff --git a/src/heap/heap.h b/src/heap/heap.h
index d60a3f079b035e1e6bf98b5a944dbe33b3023452..dcf7bdea0ac812972304bd382d52b0a1f4c5eff2 100644
--- a/src/heap/heap.h
+++ b/src/heap/heap.h
@@ -883,13 +883,6 @@ class Heap {
return last_array_buffer_in_list_;
}
- void set_new_array_buffer_views_list(Object* object) {
- new_array_buffer_views_list_ = object;
- }
- Object* new_array_buffer_views_list() const {
- return new_array_buffer_views_list_;
- }
-
void set_allocation_sites_list(Object* object) {
allocation_sites_list_ = object;
}
@@ -1496,18 +1489,6 @@ class Heap {
bool deserialization_complete() const { return deserialization_complete_; }
- bool migration_failure() const { return migration_failure_; }
- void set_migration_failure(bool migration_failure) {
- migration_failure_ = migration_failure;
- }
-
- bool previous_migration_failure() const {
- return previous_migration_failure_;
- }
- void set_previous_migration_failure(bool previous_migration_failure) {
- previous_migration_failure_ = previous_migration_failure;
- }
-
protected:
// Methods made available to tests.
@@ -1682,11 +1663,6 @@ class Heap {
Object* last_array_buffer_in_list_;
Object* allocation_sites_list_;
- // This is a global list of array buffer views in new space. When the views
- // get promoted, they are removed form the list and added to the corresponding
- // array buffer.
- Object* new_array_buffer_views_list_;
-
// List of encountered weak collections (JSWeakMap and JSWeakSet) during
// marking. It is initialized during marking, destroyed after marking and
// contains Smi(0) while marking is not active.
@@ -2017,7 +1993,6 @@ class Heap {
void ProcessNativeContexts(WeakObjectRetainer* retainer);
void ProcessArrayBuffers(WeakObjectRetainer* retainer, bool stop_after_young);
- void ProcessNewArrayBufferViews(WeakObjectRetainer* retainer);
void ProcessAllocationSites(WeakObjectRetainer* retainer);
// Deopts all code that contains allocation instruction which are tenured or
@@ -2177,13 +2152,6 @@ class Heap {
bool concurrent_sweeping_enabled_;
- // A migration failure indicates that a semi-space copy of an object during
- // a scavenge failed and the object got promoted instead.
- bool migration_failure_;
-
- // A migration failure happened in the previous scavenge.
- bool previous_migration_failure_;
-
friend class AlwaysAllocateScope;
friend class Deserializer;
friend class Factory;
« no previous file with comments | « src/heap-snapshot-generator.cc ('k') | src/heap/heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698