src/elements.h - Issue 1107843002: Reland "Remove the weak list of views from array buffers"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/elements.h

Issue 1107843002: Reland "Remove the weak list of views from array buffers" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: use bounds check Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/elements.h

diff --git a/src/elements.h b/src/elements.h

index 1d80b25891009325a002000fd868a22b732b45a1..e743849ff7085ca641edaaaa65571c9c90f91101 100644

--- a/src/elements.h

+++ b/src/elements.h

@@ -183,7 +183,8 @@ class ElementsAccessor {

protected:

friend class SloppyArgumentsElementsAccessor;

- virtual uint32_t GetCapacity(Handle<FixedArrayBase> backing_store) = 0;

+ virtual uint32_t GetCapacity(Handle<JSObject> holder,

+ Handle<FixedArrayBase> backing_store) = 0;

// Element handlers distinguish between indexes and keys when they manipulate

// elements. Indexes refer to elements in terms of their location in the

« no previous file with comments | « src/code-stubs-hydrogen.cc ('k') | src/elements.cc » ('j') | no next file with comments »