Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: src/objects-debug.cc

Issue 1107843002: Reland "Remove the weak list of views from array buffers" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: use bounds check Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/disasm.h" 7 #include "src/disasm.h"
8 #include "src/disassembler.h" 8 #include "src/disassembler.h"
9 #include "src/heap/objects-visiting.h" 9 #include "src/heap/objects-visiting.h"
10 #include "src/jsregexp.h" 10 #include "src/jsregexp.h"
(...skipping 823 matching lines...) Expand 10 before | Expand all | Expand 10 after
834 } 834 }
835 835
836 836
837 void JSArrayBufferView::JSArrayBufferViewVerify() { 837 void JSArrayBufferView::JSArrayBufferViewVerify() {
838 CHECK(IsJSArrayBufferView()); 838 CHECK(IsJSArrayBufferView());
839 JSObjectVerify(); 839 JSObjectVerify();
840 VerifyPointer(buffer()); 840 VerifyPointer(buffer());
841 CHECK(buffer()->IsJSArrayBuffer() || buffer()->IsUndefined() 841 CHECK(buffer()->IsJSArrayBuffer() || buffer()->IsUndefined()
842 || buffer() == Smi::FromInt(0)); 842 || buffer() == Smi::FromInt(0));
843 843
844 VerifyPointer(byte_offset()); 844 VerifyPointer(raw_byte_offset());
845 CHECK(byte_offset()->IsSmi() || byte_offset()->IsHeapNumber() 845 CHECK(raw_byte_offset()->IsSmi() || raw_byte_offset()->IsHeapNumber() ||
846 || byte_offset()->IsUndefined()); 846 raw_byte_offset()->IsUndefined());
847 847
848 VerifyPointer(byte_length()); 848 VerifyPointer(raw_byte_length());
849 CHECK(byte_length()->IsSmi() || byte_length()->IsHeapNumber() 849 CHECK(raw_byte_length()->IsSmi() || raw_byte_length()->IsHeapNumber() ||
850 || byte_length()->IsUndefined()); 850 raw_byte_length()->IsUndefined());
851 } 851 }
852 852
853 853
854 void JSTypedArray::JSTypedArrayVerify() { 854 void JSTypedArray::JSTypedArrayVerify() {
855 CHECK(IsJSTypedArray()); 855 CHECK(IsJSTypedArray());
856 JSArrayBufferViewVerify(); 856 JSArrayBufferViewVerify();
857 VerifyPointer(length()); 857 VerifyPointer(raw_length());
858 CHECK(length()->IsSmi() || length()->IsHeapNumber() 858 CHECK(raw_length()->IsSmi() || raw_length()->IsHeapNumber() ||
859 || length()->IsUndefined()); 859 raw_length()->IsUndefined());
860 860
861 VerifyPointer(elements()); 861 VerifyPointer(elements());
862 } 862 }
863 863
864 864
865 void JSDataView::JSDataViewVerify() { 865 void JSDataView::JSDataViewVerify() {
866 CHECK(IsJSDataView()); 866 CHECK(IsJSDataView());
867 JSArrayBufferViewVerify(); 867 JSArrayBufferViewVerify();
868 } 868 }
869 869
(...skipping 411 matching lines...) Expand 10 before | Expand all | Expand 10 after
1281 ? it.rinfo()->target_cell() 1281 ? it.rinfo()->target_cell()
1282 : it.rinfo()->target_object(); 1282 : it.rinfo()->target_object();
1283 CHECK(!CanLeak(target, heap, skip_weak_cell)); 1283 CHECK(!CanLeak(target, heap, skip_weak_cell));
1284 } 1284 }
1285 } 1285 }
1286 1286
1287 1287
1288 #endif // DEBUG 1288 #endif // DEBUG
1289 1289
1290 } } // namespace v8::internal 1290 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698