Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Unified Diff: mojo/dart/embedder/dart_debugger.cc

Issue 1107803002: Add Observatory to sky dart_controller (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/dart/embedder/dart_debugger.cc
diff --git a/mojo/dart/embedder/dart_debugger.cc b/mojo/dart/embedder/dart_debugger.cc
index 31e9ee4b5fb9a6534eccf618e5a56dd98842cd8c..8c9398ac2aa0996c15c0e1419736c62b0605b9e9 100644
--- a/mojo/dart/embedder/dart_debugger.cc
+++ b/mojo/dart/embedder/dart_debugger.cc
@@ -7,7 +7,7 @@
#include "dart/runtime/include/dart_api.h"
#include "dart/runtime/include/dart_debugger_api.h"
#include "dart/runtime/include/dart_native_api.h"
-#include "mojo/dart/embedder/dart_debugger.h"
+#include "dart_debugger.h"
namespace mojo {
namespace dart {
@@ -132,6 +132,7 @@ void DartDebugger::RemoveIsolate(Dart_IsolateId id) {
DartDebuggerIsolate* isolate = isolates_[i];
if (id == isolate->id()) {
isolates_.erase(isolates_.begin() + i);
+ delete isolate;
eseidel 2015/04/27 17:38:37 Was this just a bug? Do we need to unittest it?
Cutch 2015/05/05 22:07:22 We were leaking this memory (small struct for ever
return;
}
}

Powered by Google App Engine
This is Rietveld 408576698