Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: tests/standalone/io/test_runner_exit_code_test.dart

Issue 11078007: Add test that test.dart returns non-zero exit code for failing runs. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/io/test_runner_exit_code_script.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/test_runner_exit_code_test.dart
diff --git a/tests/standalone/io/test_runner_exit_code_test.dart b/tests/standalone/io/test_runner_exit_code_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..9799ebbd897740b9f42244e4ff1655cfff6708b2
--- /dev/null
+++ b/tests/standalone/io/test_runner_exit_code_test.dart
@@ -0,0 +1,31 @@
+// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+#import('dart:io');
+
+void runTests(String executable, String script, Iterator iterator) {
ahe 2012/10/08 07:58:55 Consider using a list instead of an iterator...
+ if (iterator.hasNext()) {
+ var progressIndicator = iterator.next();
ahe 2012/10/08 07:58:56 ... then these two lines can be: for (String prog
Mads Ager (google) 2012/10/08 08:00:49 They could, but then you would start all the proce
ahe 2012/10/08 08:02:43 Doh. I misread the code :-)
+ Process.run(executable, [script, progressIndicator]).then((result) {
+ Expect.equals(1, result.exitCode);
+ if (progressIndicator == 'buildbot') {
+ Expect.isTrue(result.stdout.contains("@@@STEP_FAILURE@@@"));
Emily Fortuna 2012/10/08 17:50:06 The "@@@STEP_FAILURE@@" string is only printed out
+ }
+ runTests(executable, script, iterator);
+ });
+ }
+}
+
+main() {
+ var scriptPath = new Path.fromNative(new Options().script);
+ var scriptDirPath = scriptPath.directoryPath;
+ var exitCodeScriptPath =
+ scriptDirPath.append('test_runner_exit_code_script.dart');
+ var script = exitCodeScriptPath.toNativePath();
+ var executable = new Options().executable;
+ var progressTypes = ['compact', 'color', 'line', 'verbose',
+ 'status', 'buildbot'];
+ var iterator = progressTypes.iterator();
+ runTests(executable, script, iterator);
+}
« no previous file with comments | « tests/standalone/io/test_runner_exit_code_script.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698