Disable BeginFrame scheduling for OOPIF

Disable BeginFrame scheduling for OOPIF

This cl disables BeginFrame scheduling for OOPIF.
We will enable this for OOPIF when we have a architecture for delivering
BeginFrame message for OOPIF.

R=kenrb@chromium.org, brianderson@chromium.org, creis@chromium.org
BUG=471411
Committed: https://crrev.com/628f981852463c76f764e8b3da4d6bd415d4a3c7
Cr-Commit-Position: refs/heads/master@{#327169}

[simonhong, 2015-04-25 00:39:52]

simonhong@chromium.org changed reviewers:
+ brianderson@chromium.org
- briandersion@chromium.org

[simonhong, 2015-04-25 00:40:40]

simonhong@chromium.org changed reviewers:
+ creis@chromium.org

[simonhong, 2015-04-25 00:43:48]

PTAL!

[brianderson, 2015-04-25 01:04:57]

lgtm, but Ken or Charlie should definitely have a look before landing.

[kenrb, 2015-04-27 13:37:56]

lgtm

[Charlie Reis, 2015-04-27 16:47:18]

Ok, LGTM with nits.

https://codereview.chromium.org/1107763002/diff/40001/content/renderer/gpu/re...
File content/renderer/gpu/render_widget_compositor.cc (right):

https://codereview.chromium.org/1107763002/diff/40001/content/renderer/gpu/re...
content/renderer/gpu/render_widget_compositor.cc:238: // TODO(simonhong): Apply
BeginFrame scheduling for sub-frame.
Please list a bug number here.

https://codereview.chromium.org/1107763002/diff/40001/content/renderer/render...
File content/renderer/render_widget.h (right):

https://codereview.chromium.org/1107763002/diff/40001/content/renderer/render...
content/renderer/render_widget.h:697: // Whether this RenderWidget is for
sub-frame or not.
nit: is for an out-of-process iframe or not.

(We don't create widgets for same-process iframes.)

[simonhong, 2015-04-27 20:49:33]

https://codereview.chromium.org/1107763002/diff/40001/content/renderer/gpu/re...
File content/renderer/gpu/render_widget_compositor.cc (right):

https://codereview.chromium.org/1107763002/diff/40001/content/renderer/gpu/re...
content/renderer/gpu/render_widget_compositor.cc:238: // TODO(simonhong): Apply
BeginFrame scheduling for sub-frame.
On 2015/04/27 16:47:18, Charlie Reis wrote:
> Please list a bug number here.

Done.

https://codereview.chromium.org/1107763002/diff/40001/content/renderer/render...
File content/renderer/render_widget.h (right):

https://codereview.chromium.org/1107763002/diff/40001/content/renderer/render...
content/renderer/render_widget.h:697: // Whether this RenderWidget is for
sub-frame or not.
On 2015/04/27 16:47:18, Charlie Reis wrote:
> nit: is for an out-of-process iframe or not.
> 
> (We don't create widgets for same-process iframes.)

Done.

https://codereview.chromium.org/1107763002/diff/40001/content/renderer/render...
content/renderer/render_widget.h:698: bool for_subframe_;
Changed to for_oopif_, too.

[simonhong, 2015-04-27 21:32:53]

The CQ bit was checked by simonhong@chromium.org

[simonhong, 2015-04-27 21:32:54]

The patchset sent to the CQ was uploaded after l-g-t-m from kenrb@chromium.org,
creis@chromium.org, brianderson@chromium.org
Link to the patchset: https://codereview.chromium.org/1107763002/#ps60001
(title: "Fix comment and use for_oopif_.")

[commit-bot: I haz the power, 2015-04-27 21:34:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1107763002/60001

[commit-bot: I haz the power, 2015-04-27 23:13:27]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-27 23:14:16]

Patchset 4 (id:??) landed as
https://crrev.com/628f981852463c76f764e8b3da4d6bd415d4a3c7
Cr-Commit-Position: refs/heads/master@{#327169}