Adding Java style presubmit check.

tools/android/checkstyle/checkstyle.py

+# Copyright 2013 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+""" Script that is used by PRESUBMIT.py to run style checks on Java files."""

[M-A Ruel, 2013/12/10 13:26:51]

""Script

[aurimas (slooooooooow), 2013/12/10 17:12:32]

Done.

+
+

[M-A Ruel, 2013/12/10 13:26:51]

remove one empty line

[aurimas (slooooooooow), 2013/12/10 17:12:32]

Done.

+import os
+import subprocess
+
+
+def RunCheckstyle(input_api, output_api, style_file):
+  if not os.path.exists(style_file):
+    file_error = ('  Java checkstyle configuration file is missing: '
+                  + style_file)
+    return [output_api.PresubmitError(file_error)]
+
+  # Filter out non-Java files and files that were deleted.
+  java_files = [x.LocalPath() for x in input_api.AffectedFiles(False, False)
+                if os.path.splitext(x.LocalPath())[1].lower() == '.java']

[M-A Ruel, 2013/12/10 13:26:51]

are .JAVA files valid?

[aurimas (slooooooooow), 2013/12/10 17:12:32]

Done.

+  if not java_files:
+    return []
+
+  # Run checkstyle
+  checkstyle_env = os.environ.copy()
+  checkstyle_env['JAVA_CMD'] = 'java'
+  try:
+    check = subprocess.Popen(['checkstyle', '-c', style_file] + java_files,
+                             stdout=subprocess.PIPE, env=checkstyle_env)
+    stdout, _ = check.communicate()
+    if check.returncode == 0:
+      return []
+  except OSError as e:
+    import errno
+    if e.errno == errno.ENOENT:
+      install_error = ('  checkstyle is not installed. Please run '
+                       'build/install-build-deps-android.sh')
+      return [output_api.PresubmitPromptWarning(install_error)]
+
+  # Remove non-error values from stdout
+  errors = stdout.splitlines()
+  output_header = 'Starting audit...'

[M-A Ruel, 2013/12/10 13:26:51]

These two are only used once so I wouldn't make them a variable.

[aurimas (slooooooooow), 2013/12/10 17:12:32]

Done.

+  output_footer = 'Audit done.'
+
+  if errors and errors[0] == output_header:
+    del errors[0]
+  if errors and errors[-1] == output_footer:
+    del errors[-1]
+
+  # Filter out warnings
+  errors = [x for x in errors if 'warning: ' not in x]
+  if not errors:
+    return []
+  else:

[M-A Ruel, 2013/12/10 13:26:51]

optional: I'd remove the else, it's not necessary.

[aurimas (slooooooooow), 2013/12/10 17:12:32]

Done.

+    local_path = input_api.PresubmitLocalPath()
+    output = []
+    for error in errors:
+      # Change the full file path to relative path in the output lines
+      full_path, end = error.split(':', 1)
+      rel_path = os.path.relpath(full_path, local_path)
+      output.append('  %s:%s' % (rel_path, end))
+    return [output_api.PresubmitPromptWarning('\n'.join(output))]