chrome/browser/ui/views/tab_modal_confirm_dialog_views.cc - Issue 11077006: Correct padding and focus ring for frameless constrained window dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tab_modal_confirm_dialog_views.cc

Issue 11077006: Correct padding and focus ring for frameless constrained window dialog (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Add comments and ASCII art. More clear implementation of client insets. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/constrained_window_frame_simple.cc ('K') | « chrome/browser/ui/views/constrained_window_frame_simple.cc ('k') | ui/views/controls/button/chrome_style.cc » ('j') | ui/views/controls/button/chrome_style.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/tab_modal_confirm_dialog_views.cc

diff --git a/chrome/browser/ui/views/tab_modal_confirm_dialog_views.cc b/chrome/browser/ui/views/tab_modal_confirm_dialog_views.cc

index 1538a9a85f6945de2a84f26d5d45295328c70d76..c61fb377f2bd884b8a9c144ae75a812e816dc2c3 100644

--- a/chrome/browser/ui/views/tab_modal_confirm_dialog_views.cc

+++ b/chrome/browser/ui/views/tab_modal_confirm_dialog_views.cc

@@ -32,6 +32,7 @@ const int kChromeStyleInterRowVerticalSpacing = 20;

const int kChromeStyleButtonVEdgeMargin = 0;

const int kChromeStyleButtonHEdgeMargin = 0;

const int kChromeStyleDialogButtonLabelSpacing = 24;

+const int kChromeStyleButtonContentSpacing = 0;

views::MessageBoxView::InitParams CreateMessageBoxViewInitParams(

const string16& message)

@@ -112,6 +113,7 @@ views::ClientView* TabModalConfirmDialogViews::CreateClientView(

params.button_label_spacing = kChromeStyleDialogButtonLabelSpacing;

params.text_button_factory =

&views::DialogClientView::CreateChromeStyleDialogButton;

+ params.button_content_spacing = kChromeStyleButtonContentSpacing;

return new views::DialogClientView(widget, GetContentsView(), params);

}