chrome/browser/ui/views/constrained_window_views.cc - Issue 11077006: Correct padding and focus ring for frameless constrained window dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/constrained_window_views.cc

Issue 11077006: Correct padding and focus ring for frameless constrained window dialog (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Simplify insets. Update WebUI paddings for close button Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/constrained_window_frame_simple.cc ('k') | chrome/browser/ui/views/tab_modal_confirm_dialog_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/constrained_window_views.cc

diff --git a/chrome/browser/ui/views/constrained_window_views.cc b/chrome/browser/ui/views/constrained_window_views.cc

index 2856118440e942e16e5f7234220b2fefbfb4bae6..1a33300f2170c0b850deacbbd13919bc1226b38e 100644

--- a/chrome/browser/ui/views/constrained_window_views.cc

+++ b/chrome/browser/ui/views/constrained_window_views.cc

@@ -611,8 +611,19 @@ ConstrainedWindowViews::ConstrainedWindowViews(

#endif

Init(params);

- if (frameless_)

+ if (frameless_) {

+ // Set the dialog background color.

+ if (widget_delegate && widget_delegate->AsDialogDelegate()) {

+ views::Background* background = views::Background::CreateSolidBackground(

+ ConstrainedWindow::GetBackgroundColor());

+ views::DialogClientView* dialog_client_view =

+ widget_delegate->AsDialogDelegate()->GetDialogClientView();

+ if (dialog_client_view)

+ dialog_client_view->set_background(background);

please use gerrit instead 2012/10/11 00:39:40 Adding this back in, because this background is st

+ }

PositionFramelessWindow();

+ }

ConstrainedWindowTabHelper* constrained_window_tab_helper =

ConstrainedWindowTabHelper::FromWebContents(web_contents_);