chrome/browser/ui/views/constrained_window_frame_simple.h - Issue 11077006: Correct padding and focus ring for frameless constrained window dialog

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/constrained_window_frame_simple.h

Issue 11077006: Correct padding and focus ring for frameless constrained window dialog (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Add comments and ASCII art. More clear implementation of client insets. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/constrained_window.h ('K') | « chrome/browser/ui/constrained_window.h ('k') | chrome/browser/ui/views/constrained_window_frame_simple.cc » ('j') | chrome/browser/ui/views/constrained_window_frame_simple.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_VIEWS_CONSTRAINED_WINDOW_FRAME_SIMPLE_H_	5 #ifndef CHROME_BROWSER_UI_VIEWS_CONSTRAINED_WINDOW_FRAME_SIMPLE_H_

6 #define CHROME_BROWSER_UI_VIEWS_CONSTRAINED_WINDOW_FRAME_SIMPLE_H_	6 #define CHROME_BROWSER_UI_VIEWS_CONSTRAINED_WINDOW_FRAME_SIMPLE_H_

7	7

8 #include "base/memory/scoped_ptr.h"	8 #include "base/memory/scoped_ptr.h"

9 #include "ui/views/controls/button/button.h"	9 #include "ui/views/controls/button/button.h"

10 #include "ui/views/window/non_client_view.h"	10 #include "ui/views/window/non_client_view.h"

(...skipping 53 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
64 HeaderViews* CreateDefaultHeaderView();	64 HeaderViews* CreateDefaultHeaderView();

65	65

66 views::ImageButton* CreateCloseButton();	66 views::ImageButton* CreateCloseButton();

67	67

68 ConstrainedWindowViews* container_;	68 ConstrainedWindowViews* container_;

69	69

70 views::LayoutManager* layout_;	70 views::LayoutManager* layout_;

71	71

72 scoped_ptr<HeaderViews> header_views_;	72 scoped_ptr<HeaderViews> header_views_;

73	73

	74 gfx::Insets client_insets_;
	Mike Wittman 2012/10/09 22:55:46 For clarity, make this const. For clarity, make this const. please use gerrit instead 2012/10/10 19:12:58 Done. Show quoted text On 2012/10/09 22:55:46, Mike Wittman wrote: > For clarity, make this const. Done.
	75

74 DISALLOW_COPY_AND_ASSIGN(ConstrainedWindowFrameSimple);	76 DISALLOW_COPY_AND_ASSIGN(ConstrainedWindowFrameSimple);

75 };	77 };

76 #endif // CHROME_BROWSER_UI_VIEWS_CONSTRAINED_WINDOW_FRAME_SIMPLE_H_	78 #endif // CHROME_BROWSER_UI_VIEWS_CONSTRAINED_WINDOW_FRAME_SIMPLE_H_

OLD	NEW