Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Issue 1107683003: Remove dependency of history_unittests on content::DownloadInterruptReason (Closed)

Created:
5 years, 8 months ago by sdefresne
Modified:
5 years, 8 months ago
Reviewers:
droger
CC:
chromium-reviews, browser-components-watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dependency of history_unittests on content::DownloadInterruptReason Export kTestDownloadInterruptReason{None,Crash} and use them in history_unittests.cc to remove dependency on content::DownloadInterruptReason. Remove unused #includes. BUG=370850 Committed: https://crrev.com/2f6155f7d07aed46cdce253445ab6ac08b3b2ac9 Cr-Commit-Position: refs/heads/master@{#326805}

Patch Set 1 #

Patch Set 2 : Remove duplicate #include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -21 lines) Patch
M chrome/browser/history/history_unittest.cc View 1 12 chunks +12 lines, -19 lines 0 comments Download
M components/history/core/test/test_history_database.h View 2 chunks +8 lines, -0 lines 0 comments Download
M components/history/core/test/test_history_database.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107683003/1
5 years, 8 months ago (2015-04-24 14:40:12 UTC) #2
sdefresne
PTAL
5 years, 8 months ago (2015-04-24 14:42:08 UTC) #4
droger
lgtm
5 years, 8 months ago (2015-04-24 14:44:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107683003/20001
5 years, 8 months ago (2015-04-24 14:51:23 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-24 15:46:37 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 15:47:37 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2f6155f7d07aed46cdce253445ab6ac08b3b2ac9
Cr-Commit-Position: refs/heads/master@{#326805}

Powered by Google App Engine
This is Rietveld 408576698