Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 1107663003: Properly attach InfoBarContainer when it is swapped to a new WebContents (Closed)

Created:
5 years, 8 months ago by gone
Modified:
5 years, 8 months ago
Reviewers:
newt (away)
CC:
chromium-reviews, David Trainor- moved to gerrit, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2357
Target Ref:
refs/pending/heads/2357
Project:
chromium
Visibility:
Public.

Description

Properly attach InfoBarContainer when it is swapped to a new WebContents * Moves the swapping of the InfoBarService from TabAndroid::SwapWebContents() to after TabAndroid::InitWebContents() is called from Tab.setContentViewCore(). This is necessary because InitWebContents attaches the InfoBarService to the WebContents; trying to swap before this point means that the InfoBarContainer will be observing nothing. * Fixes the ChromeShellActivity/Tab to properly update the ContentViewCore when it is swapped. This fixes the "Distill page" menu item. * Adds a test to try to prevent this from happening in the future. BUG=469026 TEST=InfoBarTest.testInfoBarContainerSwapsWebContents TBR=newt Review URL: https://codereview.chromium.org/1049383008 Cr-Commit-Position: refs/heads/master@{#326642} Committed: https://chromium.googlesource.com/chromium/src/+/ffcc397d404ede173c2c93e4c2a2969459fe9558

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
gone
5 years, 8 months ago (2015-04-24 00:39:13 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ffcc397d404ede173c2c93e4c2a2969459fe9558 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698