Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1107653003: Enable proguard for ChromeShell (Closed)

Created:
5 years, 7 months ago by cjhopman
Modified:
5 years, 7 months ago
Reviewers:
nyquist
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@proguard-refactor
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable proguard for ChromeShell Currently we don't have any real uses of proguard in non-internal code. This makes it really easy to break the proguard rules. This enables proguard for ChromeShell with a fairly conservative configuration (for example, everything in org.chromium.** is kept). Committed: https://crrev.com/0be554b77381ec6703d673fb7f688dac97736f07 Cr-Commit-Position: refs/heads/master@{#327547}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -2 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizerTest.java View 3 chunks +4 lines, -2 lines 0 comments Download
A chrome/android/shell/java/proguard.flags View 1 chunk +63 lines, -0 lines 0 comments Download
M chrome/chrome_shell.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
cjhopman
nyquist: *
5 years, 7 months ago (2015-04-27 18:46:26 UTC) #2
nyquist
lgtm. including everything in org.chromium.** simplified things quite a bit.
5 years, 7 months ago (2015-04-27 23:15:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107653003/1
5 years, 7 months ago (2015-04-29 18:21:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107653003/1
5 years, 7 months ago (2015-04-29 18:22:44 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 19:31:19 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 19:33:10 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0be554b77381ec6703d673fb7f688dac97736f07
Cr-Commit-Position: refs/heads/master@{#327547}

Powered by Google App Engine
This is Rietveld 408576698