mojo/shell/out_of_process_native_runner.cc - Issue 1107633002: Improve multi-process debugging.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/shell/out_of_process_native_runner.cc

Issue 1107633002: Improve multi-process debugging. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/shell/out_of_process_native_runner.cc

diff --git a/mojo/shell/out_of_process_native_runner.cc b/mojo/shell/out_of_process_native_runner.cc

index 181a4d2526a985714c389f24220cda673c6f09a4..f09ea829d004e23441e71b8ace1f3c59d27291c7 100644

--- a/mojo/shell/out_of_process_native_runner.cc

+++ b/mojo/shell/out_of_process_native_runner.cc

@@ -38,7 +38,8 @@ void OutOfProcessNativeRunner::Start(

DCHECK(app_completed_callback_.is_null());

app_completed_callback_ = app_completed_callback;

- child_process_host_.reset(new ChildProcessHost(context_));

+ std::string name = app_path.BaseName().RemoveExtension().MaybeAsASCII();

+ child_process_host_.reset(new ChildProcessHost(context_, name));

child_process_host_->Start();

// TODO(vtl): |app_path.AsUTF8Unsafe()| is unsafe.

« no previous file with comments | « mojo/shell/context.cc ('k') | mojo/shell/switches.h » ('j') | no next file with comments »