Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1232)

Unified Diff: mojo/shell/child_process_host.h

Issue 1107633002: Improve multi-process debugging. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/shell/child_process.cc ('k') | mojo/shell/child_process_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/child_process_host.h
diff --git a/mojo/shell/child_process_host.h b/mojo/shell/child_process_host.h
index 61b357b9eaa8740ad0f994c954a1c419fd49ca95..bc302064255d6febda7bbd0fd42818a806a8bd7a 100644
--- a/mojo/shell/child_process_host.h
+++ b/mojo/shell/child_process_host.h
@@ -30,7 +30,8 @@ class Context;
// remained alive until the |on_app_complete| callback is called.
class ChildProcessHost {
public:
- explicit ChildProcessHost(Context* context);
+ // |name| is just for debugging ease.
+ ChildProcessHost(Context* context, const std::string& name);
virtual ~ChildProcessHost();
// |Start()|s the child process; calls |DidStart()| (on the thread on which
@@ -65,6 +66,7 @@ class ChildProcessHost {
void DidCreateChannel(embedder::ChannelInfo* channel_info);
Context* const context_;
+ const std::string name_;
base::Process child_process_;
embedder::PlatformChannelPair platform_channel_pair_;
ChildControllerPtr controller_;
« no previous file with comments | « mojo/shell/child_process.cc ('k') | mojo/shell/child_process_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698