Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1107613003: [Metrics, Cleanup] Replace a misleading TODO with documentation. (Closed)

Created:
5 years, 8 months ago by Ilya Sherman
Modified:
5 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, bmcquade1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Metrics, Cleanup] Replace a misleading TODO with documentation. BUG=none TEST=none R=asvitkine@chromium.org Committed: https://crrev.com/720823c1a3a190140c34875577af67c63abdd6e8 Cr-Commit-Position: refs/heads/master@{#326887}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M components/metrics/net/network_metrics_provider.cc View 2 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Ilya Sherman
5 years, 8 months ago (2015-04-23 23:39:55 UTC) #1
Alexei Svitkine (slow)
lgtm
5 years, 8 months ago (2015-04-24 20:09:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107613003/1
5 years, 8 months ago (2015-04-24 20:11:51 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 21:50:33 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 21:52:20 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/720823c1a3a190140c34875577af67c63abdd6e8
Cr-Commit-Position: refs/heads/master@{#326887}

Powered by Google App Engine
This is Rietveld 408576698